Hi Eliot,
Yes, the github version lacks that line. My pull request[1] has this fix, along with a few other fixes and improvments, but Tobias didn't like the image-sided SAN certificate validation scheme, so none of those have been merged. In the meanwhile I've started rewriting a few things, like logging, certificate serialization (so that it's accessible from the image), but I still haven't finished domain name validation.
Levente
[1] https://github.com/itsmeront/squeakssl/pull/3/files
On Fri, 24 Jul 2015, Eliot Miranda wrote:
Hi Tobias, Levente and Marcel,
I'm just integrating your v0.2.0 sources into Cog and I see that in sqDestroySSL at line 139 in the Cog version of sqUnixOpenSSL.c there's the line
if(ssl->serverName) free(ssl->serverName);
but that's missing from the 0.2.0 version. It looks to me like the Cog version is correct. Is that a storage leak in 0.2.0 or am I misreading the code (sqSetStringPropertySSL), and the line should not be
present?
On Wed, Apr 22, 2015 at 2:35 PM, <Das.Linux@gmx.de> wrote:
Dear Smalltalkers
as a follow up to the SqueakSSL changes sent around yesterday…
On 21.04.2015, at 16:52, Tobias Pape <Das.Linux@gmx.de> wrote:
> Dear Smalltalkers
>
> Starting with Levente Uzonyi's patches to the Linux version
> of the SqueakSSL-Plugin, we (Marcel Taeumel and me) have
> ported this to the OS X and Windows version as well.
>
> Find three binaries[1] that can be used instead of
> the ones found on versions found on SqueakSSL's google code
> page.
> […]
> [1]: http://forum.world.st/file/n4820846/squeakssl.zip
… I'd like to thank Levente Uzonyi and Ron Teitelbaum for their
input and providing infrastructure.
I put together all files and have uploaded them to the new
(in the googlecode-export sense) SqueakSSL gitHub project:
https://github.com/itsmeront/squeakssl/
And tagged a release as v0.2.0 with a Zip of all binaries (linux32/64,osx,windows)
https://github.com/itsmeront/squeakssl/releases/tag/v0.2.0
(scroll to bottom for the binaries zip: squeakssl_v0.2.0.zip)
I hope this comes in handy for anyone who wants to play around with that.
Best
-Tobias
--
_,,,^..^,,,_
best, Eliot