Hi David, I tried your patch on Linux 64x64 and it causes no problems. The net effect is that the "hint" for the mmap() call is an address about 150k higher, which should be harmless on any platform and obviously is helpful for Solaris. My only suggestion would be to add a comment in the code to explain that this offset adjustment is required for Solaris and harmless otherwise.

I would suggest that you just go ahead and open a pull request. That will make it easier for one or more people to try this out, and the pull request will cause no problems because it can just be closed if the patch is not accepted.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.