[Seaside-dev] Issue 64 in seaside: Seaside-Squeak-Core String>>#trimBlanks method inhibits porting

[codesite-noreply at google.com]

Issue 64: Seaside-Squeak-Core String>>#trimBlanks method inhibits porting
http://code.google.com/p/seaside/issues/detail?id=64

New issue report by wembley.instantiations:
What steps will reproduce the problem?

1. Inspect:  (Character cr asString, '    abc') trimBlanks

What is the expected output? What do you see instead?

On Squeak and Dolphin, I see 'abc'; on VW and VA Smalltalk I see '
   abc' (a CR, three spaces, and 3 letters).

What version of the product are you using? On what operating system?

Seaside-Core pmm.141
Seaside-Squeak-Core lr.44
Seaside-Test pmm.112

Running on WinXP

Please provide any additional information below.

Since the #trimBlanks method actually removes all separators, it seems
badly named at best.

Both VW and VA Smalltalk implement String>>#trimBlanks to remove only
spaces, not all separators.  Dolphin's #trimBlanks implementation matches
Seaside-Squeak-Core; I don't know about GST or Gemstone.

VA Smalltalk has a similar method, #trimSeparators, to remove all
separators; I have not found a similar method in other implementations.

I suggest changing the Seaside-Squeak-Core String>>#trimBlanks method (and
references to it) to String>>#trimSeparators to more-correctly describe
its function as well as aiding porting.


Issue attributes:
	Status: New
	Owner: ----
	Labels: Type-Defect Priority-Medium

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings