[Seaside-dev] Issue 227 in seaside: #halt should always halt
codesite-noreply at google.com
codesite-noreply at google.com
Wed Nov 12 00:57:52 UTC 2008
Issue 227: #halt should always halt
http://code.google.com/p/seaside/issues/detail?id=227
Comment #26 by jfitzell:
After looking at this some more, the refactoring I had done fixed way more
problems
than were caused by minor differences in functionality. So I am
reintroducing the
previous ExceptionHandler refactorings but with a few changes to satisfy
complaints
in this issue:
+ Most ErrorHandlers no longer catch Halts
+ The only one that does is WAHtmlHaltAndErrorHandler, which is in a
Squeak-specific
package, which removes the need for the platform #haltClass method. This
handler can
be used or subclassed in production
+ Code to resume WARequestContextNotFound was moved up to the top-level
WAExceptionHandler so that stepping over #requestContext will work in a
debugger,
even when not using a DebugErrorHandler
+ The text in the functional tests was updated to indicate that the results
are
handler- (and occasionaly platform-) specific
With regard to the points in Comment 24:
1. Not sure how the "out-of-the-box" experience is broken but I assume
these changes
address it
2. I'm not interested in writing out the behaviour of every error handler.
The
DebugErrorHandler is well commented and that's the only tricky one. If
someone else
wants to write this out in the test, feel free.
3. The behaviour in the old version was sketchy:
a) It relied on (in my opinon) broken Squeak Debugger behaviour and
probably didn't
work on other platforms
b) It didn't refresh; it triggered a RenderNotification which would abort
the whole
request processing phase or, if the error occurred during rendering, would
have
resulted in returning nil as a response
If you want to add a META-REFRESH tag to the #unableToResumeResponse or
something, I
guess that's fine. This only even comes up because of Squeak's weird
Debugger
behaviour on Proceed (see
http://code.google.com/p/pharo/issues/detail?id=329 )
Name: RSS-Core-jf.27
Author: jf
Time: 12 November 2008, 1:42:55 am
UUID: 33055b97-6141-b644-a3fd-683ae2b87d17
Ancestors: RSS-Core-jf.26
http://code.google.com/p/seaside/issues/detail?id=227
http://www.squeaksource.com/Seaside29/RSS-Core-jf.27.mcz
Name: Seaside-Core-jf.330
Author: jf
Time: 12 November 2008, 1:43:01 am
UUID: 7c6b79f7-f0c3-e74c-81b6-ef7b2da6250b
Ancestors: Seaside-Core-jf.327
http://www.squeaksource.com/Seaside29/Seaside-Core-jf.330.mcz
Name: Seaside-Development-jf.41
Author: jf
Time: 12 November 2008, 1:43:13 am
UUID: cbafed66-26e7-9f4e-806b-cbc94d3229dc
Ancestors: Seaside-Development-jf.39
http://www.squeaksource.com/Seaside29/Seaside-Development-jf.41.mcz
Name: Seaside-Environment-jf.28
Author: jf
Time: 12 November 2008, 1:43:20 am
UUID: 53592ccb-65c2-1140-bfaa-386010b8d69c
Ancestors: Seaside-Environment-jf.26
http://www.squeaksource.com/Seaside29/Seaside-Environment-jf.28.mcz
Name: Seaside-Session-jf.55
Author: jf
Time: 12 November 2008, 1:43:25 am
UUID: 5c4fd140-95f3-b740-8436-df9415cdb624
Ancestors: Seaside-Session-jf.53
http://www.squeaksource.com/Seaside29/Seaside-Session-jf.55.mcz
Name: Seaside-Sport-jf.3
Author: jf
Time: 12 November 2008, 1:43:29 am
UUID: a0720cfe-bc27-8a49-806f-ee69fd3d36fc
Ancestors: Seaside-Sport-pmm.2
http://www.squeaksource.com/Seaside29/Seaside-Sport-jf.3.mcz
Name: Seaside-Squeak-Email-jf.4
Author: jf
Time: 12 November 2008, 1:43:35 am
UUID: bb783f4e-7fb2-2c4e-8f1a-e758e07eb16b
Ancestors: Seaside-Squeak-Email-lr.3
http://www.squeaksource.com/Seaside29/Seaside-Squeak-Email-jf.4.mcz
Name: Seaside-Squeak-Environment-jf.16
Author: jf
Time: 12 November 2008, 1:43:39 am
UUID: 4b29e9b0-34a8-964e-891a-b215870995a2
Ancestors: Seaside-Squeak-Environment-pmm.15
http://www.squeaksource.com/Seaside29/Seaside-Squeak-Environment-jf.16.mcz
Name: Seaside-Tests-Functional-jf.26
Author: jf
Time: 12 November 2008, 1:43:44 am
UUID: 1053f0fc-51e2-0644-88db-3cf2048a87fa
Ancestors: Seaside-Tests-Functional-jf.25
http://www.squeaksource.com/Seaside29/Seaside-Tests-Functional-jf.26.mcz
Issue attribute updates:
Status: Fixed
Owner: jfitzell
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
More information about the seaside-dev
mailing list