[Seaside-dev] Re: [Seaside Commits] Seaside 2.9: Seaside-Tests-Core-lr.124.mcz

[Julian Fitzell]

If you like. As far as I'm concerned I'm happy as long as there is:

a) a rationale, reason, or goal for the change
b) a summary of the change (possibly not necessary for one-line changes)
c) a link to the issue if it resolves an issue.

Most of our commit messages follow that pattern anyway. I don't think
we need to specify templates for commit messages or anything; we just
should try to ensure that they include WHAT changed and WHY (the
meta-data already provides WHO, WHEN, and WHERE).

Julian

On Wed, Apr 22, 2009 at 4:27 AM, Lukas Renggli <renggli at gmail.com> wrote:
> Other open source projects have a few simple rules how commits are
> handled (and especially commented):
> <http://openmrs.org/wiki/Subversion_Repository_Code_of_Conduct>. Maybe
> we should adopt something like this? ;-)
>
> Lukas
>
> On Wed, Apr 22, 2009 at 10:33 AM, Julian Fitzell <jfitzell at gmail.com> wrote:
>> On Wed, Apr 22, 2009 at 1:28 AM, Paolo Bonzini <bonzini at gnu.org> wrote:
>>> Julian Fitzell wrote:
>>>> Just so we know... why? Would be nice if the commit log included a
>>>> rationale (I can see what the change was from the diff :) ).
>>>
>>> Because it made no difference.  What the author wanted, was actually
>>> #should:raise:whoseDescriptionIncludes:.
>>
>> Well something prompted the change and it's useful to know what it
>> was. Was it lint rules, personal taste, coding coventions,
>> compatibility? In this case, having read the rest of the messages on
>> the list, I now see it was a compatibility issue with VW, but it would
>> be nice to have that included in the commit log because anyone looking
>> even three days from now won't know the reason.
>>
>> Julian
>> _______________________________________________
>> seaside-dev mailing list
>> seaside-dev at lists.squeakfoundation.org
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>
>
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>