[Seaside-dev] Issue 286 in seaside: WAActionCallback>>isEnabled calls #requestContext

[codesite-noreply at google.com]

Status: Accepted
Owner: ----
Labels: Type-CleanUp Priority-Low

New issue 286 by jfitzell: WAActionCallback>>isEnabled calls #requestContext
http://code.google.com/p/seaside/issues/detail?id=286

This would prevent the callbacks being used without a #use:during: wrapper.
This is obviously not the end of the world but would be better avoided (I
think) where possible in framework code (keeping the use of #requestContext
for Components and so on that cannot have access to the context any other  
way).

I see two possible solutions:

1) WACallbackRegistry>>handle: already takes the RequestContext as a
parameter. #isEnabled could therefore be changed to #isEnabledFor: and be
given the request context.

2) It seems like (Lukas can confirm) basically the same behaviour could be
achieved by giving JSAjaxCallback a higher priority than whatever
ActionCallbacks it needs to override (4?). This way, processing would never
reach the ActionCallback.

I was originally thinking 2 was the better solution but now am thinking
maybe 1.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings