[Seaside-dev] Re: [Seaside Commits] Seaside 2.9: Seaside-Core-DamienCassou.540.mcz

[Julian Fitzell]

Hi Damien,

This code can't go in this package as it would create a circular
dependency: Core knows nothing about WARenderCanvas.

It could be added as a class extension by the Canvas package but I
wonder if there is much value. I would almost rather just change the
default value of #fullDocument to true, which would save almost as
much code.

Another further thing might be to add a method to WAResponse that
takes a WADocument and writes it on the stream. That, combined with a
method on WABuilder that returns the Document instead of a String,
might make things clearer but maybe not.

I'm going to remove this from Core right now because it might prevent
people from loading code and we can continue this discussion to figure
out where/how/if to put it back.

Julian

On Wed, Sep 2, 2009 at 1:33 AM,
<squeak-dev-noreply at lists.squeakfoundation.org> wrote:
> Damien Cassou uploaded a new version of Seaside-Core to project Seaside 2.9:
> http://www.squeaksource.com/Seaside29/Seaside-Core-DamienCassou.540.mcz
>
> ==================== Summary ====================
>
> Name: Seaside-Core-DamienCassou.540
> Author: DamienCassou
> Time: 2 September 2009, 1:30:39 am
> UUID: 9ae5f097-bfb4-4b06-8e0a-fab0a0fa9a3a
> Ancestors: Seaside-Core-pmm.539
>
> - Adds WAResponse>>buildCanvas: method to replace
>     ... nextPutAll: (WARenderCanvas builder fullDocument: true)...
>
> =============== Diff against Seaside-Core-pmm.539 ===============
>
> Item was added:
> + ----- Method: WAResponse>>buildCanvas: (in category 'convenience-rendering') -----
> + buildCanvas: aBlock
> +       |builder|
> +       builder := WARenderCanvas builder
> +                                               fullDocument: true;
> +                                               yourself.
> +       self nextPutAll: (aBlock value: builder).!
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email commits-leave at lists.seaside.st
> http://lists.seaside.st/listinfo/commits
>