[Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

[Lukas Renggli]

Is there a particular reason that you added this method?

As you can see in the method comment of #url: the variable can also
contain a string, so your method does not necessarily return what it
says.

Also consider adding a method comment and tests for any public method.

Lukas

On 21 February 2010 18:41,
<squeak-dev-noreply at lists.squeakfoundation.org> wrote:
> Gerhard Obermann uploaded a new version of Grease-Core to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/Grease-Core-obi.29.mcz
>
> ==================== Summary ====================
>
> Name: Grease-Core-obi.29
> Author: obi
> Time: 21 February 2010, 6:43:17 pm
> UUID: 79473ec4-083e-a144-aa40-4d100d2ab1e3
> Ancestors: Grease-Core-lr.28
>
> - add direct accessing method for url
>
> =============== Diff against Grease-Core-lr.28 ===============
>
> Item was added:
> + ----- Method: GRPackage>>urlSelector (in category 'accessing') -----
> + urlSelector
> +       ^ url!
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email commits-leave at lists.seaside.st
> http://lists.seaside.st/listinfo/commits
>



-- 
Lukas Renggli
http://www.lukas-renggli.ch