[Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Scriptaculous-Components-lr.96.mcz

[Julian Fitzell]

This looks totally weird...

#componentBlock: isn't an initialize method, so you should still call
#new not #basicNew
#initializeTooltipWith: doesn't seem to be an initialization method
(since it's not called from the class-side) but calling it will result
in #initialize being called twice

Julian

On Mon, Jan 25, 2010 at 2:39 PM,
<squeak-dev-noreply at lists.squeakfoundation.org> wrote:
> Lukas Renggli uploaded a new version of Scriptaculous-Components to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/Scriptaculous-Components-lr.96.mcz
>
> ==================== Summary ====================
>
> Name: Scriptaculous-Components-lr.96
> Author: lr
> Time: 25 January 2010, 11:39:47 pm
> UUID: a40555b4-b34f-4b15-b853-cc724a7ac5a4
> Ancestors: Scriptaculous-Components-jf.95
>
> - fixed some slime issues
>
> =============== Diff against Scriptaculous-Components-jf.95 ===============
>
> Item was changed:
>  ----- Method: SUWindow>>initializeTooltipWith: (in category 'initialization') -----
>  initializeTooltipWith: aString
>        | stringArray |
> +       self initialize.
>        stringArray := self initializeWith: aString.
>        stringArray size > 2
>                ifTrue: [self tooltipKey: (stringArray at: 3)].
>        ^stringArray !
>
> Item was changed:
>  ----- Method: SUWindow class>>on: (in category 'instance creation') -----
>  on: aBlock
> +       ^self basicNew
> +               componentBlock: aBlock;
> +               yourself!
> -       ^self new componentBlock: aBlock; yourself!
>
> Item was changed:
>  ----- Method: SUWindow>>initializeWith: (in category 'initialization') -----
>  initializeWith: aString
> +       self initialize.
>        arguments := aString subStrings: ','.
>        arguments size > 1
>                ifTrue: [self origin: (Point x: (arguments at: 1) asNumber y: (arguments at: 2) asNumber + 16)].
>        ^arguments!
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email commits-leave at lists.seaside.st
> http://lists.seaside.st/listinfo/commits
>