[Seaside-dev] Fwd: [Seaside Issues] Issue 789 in seaside: Running WAFilelibraryTest on Pharo3 leaves Seaside-Tests-Core package in a dirty state

[Johan Brichau]

Anybody knows why GRPharoPlatform>>removeSelector:from: was sending #removeSelectorSilently: rather than #removeSelector: to the class?

Running method removal ‘silently’ breaks something in GRPackage in Pharo3.0.
It seems GRPackage code is listening to announcements and when the removal runs silently, it is not being notified.

When you remove a loaded file from a WAFileLibrary using the Seaside infrastructure, the package would remain dirty and you get an error trying to check for its changes in Monticello.

I made a fix for it, basically cancelling the silent running of the removal in GRPharoPlatform.
I also made the Seaside testcases that compile methods run silently. Though not necessary anymore, this avoids that the compiled method gets registered in GRPackage, this avoiding the problem alltogether.

More info: http://code.google.com/p/seaside/issues/detail?id=789

Begin forwarded message:

> From: seaside at googlecode.com
> Subject: Re: [Seaside Issues] Issue 789 in seaside: Running WAFilelibraryTest on Pharo3 leaves Seaside-Tests-Core package in a dirty state
> Date: 19 Apr 2014 17:23:30 GMT+2
> To: issues at lists.seaside.st
> Reply-To: seaside-dev at lists.squeakfoundation.org, codesite-noreply at google.com
> 
> 
> Comment #2 on issue 789 by jo... at yesplan.be: Running WAFilelibraryTest on Pharo3 leaves Seaside-Tests-Core package in a dirty state
> http://code.google.com/p/seaside/issues/detail?id=789
> 
> I also changed GRPharoPlatform>>removeSelector:from: to use #removeSelector instead of #removeSelectorSilently: because it will also occur when removing methods from WAFileLibrary subclasses
> 
> I actually don't really understand why this was #removeSelectorSilently:
> 
> -- 
> You received this message because this project is configured to send all issue notifications to this address.
> You may adjust your notification preferences at:
> https://code.google.com/hosting/settings
> 
> _______________________________________________
> issues mailing list
> To unsubscribe, email issues-leave at lists.seaside.st
> http://lists.seaside.st/listinfo/issues

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/seaside-dev/attachments/20140419/3218a0f4/attachment.htm