From tim at rowledge.org Tue Sep 15 01:21:16 2020 From: tim at rowledge.org (tim Rowledge) Date: Mon, 14 Sep 2020 18:21:16 -0700 Subject: [Seaside-dev] Profiler page 'GC Stats' problem with profiler.svg ByteArray Message-ID: <94F9B290-AD4E-4913-B3D8-4A4D9D6C96C0@rowledge.org> For most excellent reason I took a look at the profiler page for my current development stuff and bravely clicked on the 'GC Stats' link. It did not go well. The fault is related to the 'profiler.svg' provided by WAToolFiles>>#profilerSvg. What happens (in Squeak 5.3-19435) is that the ByteArray returned is being turned into a mime document with a mimetype of 'svg+xml'. Unfortunately that is *not * being seen as a binary type and thus we go down the path of trying to run GRPharoUtf8CodecStream>>#nextPutAll: which sends #isByteString to the ByteArray; which dNU:. After an afternoon poking around it appears to me that the most likely cause of the issue is in WAMimeType>>#isBinary where we see this - ++++++++++++++ isBinary "answers whether the contents of a document of the receiving mime type are binary" self main = 'text' ifTrue: [ ^ false ]. self main = 'application' ifTrue: [ "application/json is text" self sub = 'json' ifTrue: [ ^ false ] ]. GRPlatform subStringsIn: self sub splitBy: $+ do: [ :each | "application/(x-)javascript and application/xml are text" (#('x-javascript' 'javascript' 'xml') includes: each) ifTrue: [ ^ false ] ]. ^ true ++++++++++++++ From the comments (hey, actual comments - well done author) it looks to me that the testing of 'sub' ought to in fact be inside the ifTrue: block above. i.e. we check for main = 'application' AND sub includes the other bits. As-is we check sub for including 'xml' even if main is not 'application'. That means that svg+xml counts as not-binary, which I strongly suspect is incorrect. So, making the obvious trivial edits we get --------------------- isBinary "answers whether the contents of a document of the receiving mime type are binary" self main = 'text' ifTrue: [ ^ false ]. self main = 'application' ifTrue: [ "application/json is text" self sub = 'json' ifTrue: [ ^ false ] . GRPlatform subStringsIn: self sub splitBy: $+ do: [ :each | "application/(x-)javascript and application/xml are text" (#('x-javascript' 'javascript' 'xml') includes: each) ifTrue: [ ^ false ] ] ]. ^ true ----------------------- ... and the profiler svg is properly rendered and the page load does not fail and there is no text sent to the Transcript from a background process that causes it to crash, which is what lead me to all this fun stuff. I've added this to a new issue on github. tim -- tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim My Go this amn keyboar oesn't have any 's. From PaulinaKarolilf41 at wp.pl Tue Sep 15 02:15:32 2020 From: PaulinaKarolilf41 at wp.pl (Elizabeth) Date: Tue, 15 Sep 2020 04:15:32 +0200 Subject: [Seaside-dev] =?utf-8?q?Seaside-dev_Profiler_page_=27GC_Stats=27_?= =?utf-8?q?problem_with_profiler=2EsvgByteArray?= Message-ID: <02b5b321761b4a9cb9438a3605c2315b@grupawp.pl> I'm a 30 y.o. woman looking for an affair. I am ready to try anything are you interested? If you want to see my pics, you can view them in my gallery: galleries.daswanitailors.com all pics On Tue, Sep 15, 2020, at 3:21 AM, Seaside wrote: >For most excellent reason I took a look at the profiler page for my current development stuff and bravely clicked on the 'GC Stats' link. It did not go well. > >The fault is related to the ' ' provided by WAToolFiles#profilerSvg. > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: Type: image/jpeg Size: 67348 bytes Desc: not available URL: From PaulinaKarolilf41 at wp.pl Tue Sep 15 02:35:27 2020 From: PaulinaKarolilf41 at wp.pl (Elizabeth) Date: Tue, 15 Sep 2020 04:35:27 +0200 Subject: [Seaside-dev] =?utf-8?q?Seaside-dev=5FProfiler=5Fpage=5F=27GC=5FS?= =?utf-8?b?dGF0cydf?= Message-ID: <8aef789582344819b965160568a43b48@grupawp.pl> I'm waiting online! Please contact me in my chat: galleries.daswanitailors.com here -------------- next part -------------- An HTML attachment was scrubbed... URL: From PaulinaKarolilf41 at wp.pl Tue Sep 15 02:52:47 2020 From: PaulinaKarolilf41 at wp.pl (Elizabeth) Date: Tue, 15 Sep 2020 04:52:47 +0200 Subject: [Seaside-dev] =?utf-8?q?Seaside-dev=5FProfiler=5Fpage=5F=27GC=5FS?= Message-ID: Plz contact me on this site: galleries.daswanitailors.com here I can't use this e-mail for chat. -------------- next part -------------- An HTML attachment was scrubbed... URL: From PaulinaKarolilf41 at wp.pl Tue Sep 15 03:12:18 2020 From: PaulinaKarolilf41 at wp.pl (Elizabeth) Date: Tue, 15 Sep 2020 05:12:18 +0200 Subject: [Seaside-dev] =?utf-8?q?Seaside-dev=5FProfiler=5Fpage=5F=27GC=5FS?= Message-ID: <63b490d18ee645cc832260e227d22d1e@grupawp.pl> I added new pics for you! You can view them here: galleries.daswanitailors.com my gallery -------------- next part -------------- An HTML attachment was scrubbed... URL: From PaulinaKarolilf41 at wp.pl Tue Sep 15 03:29:31 2020 From: PaulinaKarolilf41 at wp.pl (Elizabeth) Date: Tue, 15 Sep 2020 05:29:31 +0200 Subject: [Seaside-dev] =?utf-8?q?Seaside-dev=5FProfiler=5Fpage=5F=27GC=5FS?= Message-ID: <3b476ef6ab51451bb556b529ec574afc@grupawp.pl> You don't like me? -------------- next part -------------- An HTML attachment was scrubbed... URL: From johan at inceptive.be Tue Sep 15 06:55:05 2020 From: johan at inceptive.be (Johan Brichau) Date: Tue, 15 Sep 2020 08:55:05 +0200 Subject: [Seaside-dev] Profiler page 'GC Stats' problem with profiler.svg ByteArray In-Reply-To: <94F9B290-AD4E-4913-B3D8-4A4D9D6C96C0@rowledge.org> References: <94F9B290-AD4E-4913-B3D8-4A4D9D6C96C0@rowledge.org> Message-ID: well… no ‘Image/svg-xml’ is a text format. It’s the files that have been encoded wrong in the file library due to exactly the bug that this format was recognised as binary in the past. The file methods should have been changed while fixing the bug, which was done for others but these were forgotten. Johan > On 15 Sep 2020, at 03:21, tim Rowledge wrote: > > For most excellent reason I took a look at the profiler page for my current development stuff and bravely clicked on the 'GC Stats' link. It did not go well. > > The fault is related to the 'profiler.svg' provided by WAToolFiles>>#profilerSvg. > What happens (in Squeak 5.3-19435) is that the ByteArray returned is being turned into a mime document with a mimetype of 'svg+xml'. Unfortunately that is *not * being seen as a binary type and thus we go down the path of trying to run GRPharoUtf8CodecStream>>#nextPutAll: which sends #isByteString to the ByteArray; which dNU:. > > After an afternoon poking around it appears to me that the most likely cause of the issue is in WAMimeType>>#isBinary where we see this - > ++++++++++++++ > isBinary > "answers whether the contents of a document of the receiving mime type are binary" > self main = 'text' ifTrue: [ ^ false ]. > self main = 'application' > ifTrue: [ > "application/json is text" > self sub = 'json' ifTrue: [ ^ false ] ]. > GRPlatform subStringsIn: self sub splitBy: $+ do: [ :each | > "application/(x-)javascript and application/xml are text" > (#('x-javascript' 'javascript' 'xml') includes: each) > ifTrue: [ ^ false ] ]. > ^ true > ++++++++++++++ > > From the comments (hey, actual comments - well done author) it looks to me that the testing of 'sub' ought to in fact be inside the ifTrue: block above. > > i.e. we check for main = 'application' AND sub includes the other bits. As-is we check sub for including 'xml' even if main is not 'application'. That means that svg+xml counts as not-binary, which I strongly suspect is incorrect. > > So, making the obvious trivial edits we get > --------------------- > isBinary > "answers whether the contents of a document of the receiving mime type are binary" > self main = 'text' ifTrue: [ ^ false ]. > self main = 'application' > ifTrue: [ > "application/json is text" > self sub = 'json' ifTrue: [ ^ false ] . > GRPlatform subStringsIn: self sub splitBy: $+ do: [ :each | > "application/(x-)javascript and application/xml are text" > (#('x-javascript' 'javascript' 'xml') includes: each) > ifTrue: [ ^ false ] ] ]. > ^ true > ----------------------- > > ... and the profiler svg is properly rendered and the page load does not fail and there is no text sent to the Transcript from a background process that causes it to crash, which is what lead me to all this fun stuff. > > I've added this to a new issue on github. > > tim > -- > tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim > My Go this amn keyboar oesn't have any 's. > > > _______________________________________________ > seaside-dev mailing list > seaside-dev at lists.squeakfoundation.org > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev From PaulinaKarolilf41 at wp.pl Tue Sep 15 07:00:04 2020 From: PaulinaKarolilf41 at wp.pl (Elizabeth) Date: Tue, 15 Sep 2020 09:00:04 +0200 Subject: [Seaside-dev] =?utf-8?q?Seaside-dev=5FProfiler=5Fpage=5F=27GC=5FS?= =?utf-8?b?dGF0cydf?= Message-ID: <4fa9291460e44c448cbb16c5797a593b@grupawp.pl> Have you found my fotos? -------------- next part -------------- An HTML attachment was scrubbed... URL: From PaulinaKarolilf41 at wp.pl Tue Sep 15 07:55:43 2020 From: PaulinaKarolilf41 at wp.pl (Elizabeth) Date: Tue, 15 Sep 2020 09:55:43 +0200 Subject: [Seaside-dev] =?utf-8?q?Seaside-dev=5FProfiler=5Fpage=5F=27GC=5FS?= Message-ID: <9fb7dc6fb4c74c9eb02026182d2e1c9c@grupawp.pl> I'm online now, waiting, let's have a nice talk:) Here is my page: galleries.daswanitailors.com profile -------------- next part -------------- An HTML attachment was scrubbed... URL: From tim at rowledge.org Tue Sep 15 16:53:36 2020 From: tim at rowledge.org (tim Rowledge) Date: Tue, 15 Sep 2020 09:53:36 -0700 Subject: [Seaside-dev] Profiler page 'GC Stats' problem with profiler.svg ByteArray In-Reply-To: References: <94F9B290-AD4E-4913-B3D8-4A4D9D6C96C0@rowledge.org> Message-ID: <59F74BB3-70B2-4A8A-9563-36F5A9844456@rowledge.org> Thank you Johan; that makes perfectly good sense. Amusingly it makes my subject line a better description of the problem than my oh-so-careful analysis :-) > On 2020-09-14, at 11:55 PM, Johan Brichau wrote: > > well… no > > ‘Image/svg-xml’ is a text format. > It’s the files that have been encoded wrong in the file library due to exactly the bug that this format was recognised as binary in the past. > The file methods should have been changed while fixing the bug, which was done for others but these were forgotten. tim -- tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim If at first you don't succeed, destroy all evidence that you tried. From PaulinaKarolilf41 at wp.pl Thu Sep 17 15:12:59 2020 From: PaulinaKarolilf41 at wp.pl (Elizabeth) Date: Thu, 17 Sep 2020 17:12:59 +0200 Subject: [Seaside-dev] =?utf-8?q?Seaside-dev=5FProfiler=5Fpage=5F=27GC=5FS?= Message-ID: <18b9f5beb3c142ebbdee69cfa6a13928@grupawp.pl> Let's have a chat here: galleries.daswanitailors.com secure chat It's hard to chat via unsecure email. -------------- next part -------------- An HTML attachment was scrubbed... URL: