[Seaside] Server-Timing filter goodie

[Johan Brichau]

Thx!

Johan

> On 10 Jul 2020, at 19:34, Esteban Maringolo <emaringolo at gmail.com> wrote:
> 
> There it goes a PR then. :-)
> 
> Regards!
> 
> Esteban A. Maringolo
> 
> On Fri, Jul 10, 2020 at 1:28 PM Sven Van Caekenberghe <sven at stfx.eu> wrote:
>> 
>> 
>> 
>>> On 10 Jul 2020, at 17:39, Esteban Maringolo <emaringolo at gmail.com> wrote:
>>> 
>>> Should I create an issue in the Zinc repository then?
>> 
>> The adaptor is part of Seaside proper now. So you could create a Seaside issue I guess.
>> 
>>> Regards!
>>> 
>>> Esteban A. Maringolo
>>> 
>>> On Fri, Jul 10, 2020 at 12:30 PM Sven Van Caekenberghe <sven at stfx.eu> wrote:
>>>> 
>>>> 
>>>> 
>>>>> On 10 Jul 2020, at 15:48, Esteban Maringolo <emaringolo at gmail.com> wrote:
>>>>> 
>>>>> Note: I think there is a bug in the conversion of the headers from a
>>>>> WAResponse to ZnResponse in ZnZincServerAdaptor, since if there are
>>>>> several headers with the same name in aWAResponse, but only the last
>>>>> one remains in ZnResponse, because it does an `at:put` instead of
>>>>> adding several headers or merging them all together (as with the
>>>>> 'Set-Cookie' header).
>>>> 
>>>> Yes, from the first look of it, that seems to be correct.
>>>> 
>>>> In ZnZincServerAdaptor>>#responseFrom: aRequestContext
>>>> 
>>>>       partialHeaders keysAndValuesDo: [ :key :value |
>>>>               fullHeaders at: key put: value greaseString ].
>>>> 
>>>> should be
>>>> 
>>>>       partialHeaders keysAndValuesDo: [ :key :value |
>>>>               fullHeaders at: key add: value greaseString ].
>>>> 
>>>> Sven
>>>> _______________________________________________
>>>> seaside mailing list
>>>> seaside at lists.squeakfoundation.org
>>>> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>>> _______________________________________________
>>> seaside mailing list
>>> seaside at lists.squeakfoundation.org
>>> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>> 
>> _______________________________________________
>> seaside mailing list
>> seaside at lists.squeakfoundation.org
>> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
> _______________________________________________
> seaside mailing list
> seaside at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside