[FIX] [ENH] Intervals
Jarvis, Robert P.
Jarvisb at timken.com
Fri Dec 3 21:33:59 UTC 1999
------_=_NextPart_000_01BF3DD5.0832B032
Content-Type: text/plain
> -----Original Message-----
> From: Andrew P. Black [SMTP:apb at cse.ogi.edu]
> Sent: Wednesday, December 01, 1999 9:21 PM
> To: squeak at cs.uiuc.edu
> Subject: Re: Intervals
>
> At 13:11 -0500 1999.12.01, Jarvis, Robert P. wrote:
>
> > I also changed the class comment in Interval to state that it
> >expects integers for its start, stop, and step values,
>
> As I indicated earlier, I believe that expecting Intervals to work
> for floats is misguided, so I agree with the philosophy of making a
> separate subclass for floats.
>
> However, I would like to point out that the code that I originally
> submitted, as fixed by Dave Smith and others, does work just fine for
> fractions, where rounding errors and approximations are not a
> problem. So the class comment described above is rather more
> restrictive than necessary.
>
OK, I've altered the class comment on Interval to indicate that both
integers and fractions are acceptable start, stop, and step values. I've
also gone through all the senders of #includes:, and it appears that no
existing code will break. There were only two places that appeared to send
Interval>>includes, those being
HTMLformatter>>select:values:selections:size:multiple: and
HTMLformatter>>swikify:linkhandler:. Both of these methods should be fine
because the step value on the intervals they're using will be 1. (Dan,
where's that type inferencer?!? :-). Comments, as always, are solicited and
welcomed.
<<Interval changes.3Dece418pm.cs>>
Bob Jarvis
Compuware @ Timken
------_=_NextPart_000_01BF3DD5.0832B032
Content-Type: text/plain; name="Interval changes.3Dece418pm.cs"
; x-mac-type="65417070"
; x-mac-creator="43534F6D"
Content-Disposition: attachment; filename="Interval changes.3Dece418pm.cs"
Content-Transfer-Encoding: imap_stub
0,1991,2,6214,0,
------_=_NextPart_000_01BF3DD5.0832B032--
More information about the Squeak-dev
mailing list
|