[BUG] [FIX] Browser loses method text if new first method has
spelling fault
Norton, Chris
chrisn at Kronos.com
Fri Jun 25 15:24:42 UTC 1999
Hi Folks.
I'm terribly sorry I didn't post this fix sooner! Last month Carl Gundel &
I submitted a (hopefully) comprehensive fix for various bugs relating to the
changes we made to the Browser. Unfortunately, I neglected to post it to
this list too.
The attached change set fixes many Browser bugs. Carl & I owe a debt of
gratitude to Oshima Yoshiki for finding some of the bugs and attempting a
fix back in early April. Scott Wallace also helped to test & review our
fixes.
Well, better late then never! I hope I haven't caused you folks too much
grief!
---==> Chris
PS> The preamble on the change set gives a full description of the bugs
that were fixed and the tests that were performed on our fixes.
<<AllCatFix.21May657pm.cs>>
> -----Original Message-----
> From: Tim Rowledge [SMTP:rowledge at interval.com]
> Sent: Thursday, June 24, 1999 10:27 PM
> To: Squeak mailinglist
> Subject: [BUG] [FIX] Browser loses method text if new first method
> has spelling fault
>
> IF you attempt to save a method that has an unknown symbol (my usual
> spelling mistake!) AND you have the -all- message category selected then
> the method text is whipped out from under you.
>
> It appears to be a problem in Browser>messageCategoryListIndex:, or at
> least the usage of it within Browser>contents:notifying:. There is an
> attempt to correct for the 'wrong' category being selected and the code
> ends up clearing the code view. There is also a trivial bug in
> Browser>selectUnclassifiedCategory, where 0 is hardcoded as the index of
> the 'no messages' category; it seems more reasonable for it to be 1, since
> it follows 'all' which is an imaginary entry.
>
> As for a fix, I imagine changing the contents:notifying: code to send some
> other message that changes the category that is used to compile under but
> does not affect the browser display should work. Since both of the methods
> (#selectOriginalCategoryForCurrentMethod & #selectUnclassifiedCategory)
> are
> only used in contents:notifying: this ought to be reasonably safe.
>
> It seems to be ok if we change #selectMessageCategoryNamed: to avoid the
> display updating and change #selectUnclassifiedCategory to use it with the
> name of the category rather than the index.
>
> Possible fix changeset enclosed.
>
> tim
>
> --
> Useful random insult:- Overdue for reincarnation.
> Tim Rowledge: rowledge at interval.com (w) +1 (650) 842-6110 (w)
> tim at sumeru.stanford.edu (h) <http://sumeru.stanford.edu/tim> << File:
> BrowserBug/24Jun725pm.cs >>
Content-Type: application/octet-stream;
name="AllCatFix.21May657pm.cs"
Content-Disposition: attachment;
filename="AllCatFix.21May657pm.cs"
Attachment converted: Anon:AllCatFix.21May657pm.cs (????/----) (0000AD0E)
More information about the Squeak-dev
mailing list
|