"David T. Lewis" wrote:
> 
> On Sun, Jul 16, 2000 at 01:18:58AM -0400, David T. Lewis wrote:
> >
> > On Sat, Jul 15, 2000 at 07:26:18PM -0700, Ned Konz wrote:
> > >
> > > I'm getting an undefined external "thisSession" when running with the
> > > current VM off Sourceforge. It's even in the plugin sources that were
> > > generated.
> >
> > "thisSession" is a global declared in sqFilePrims.c. I suspect that the
> > recent plugin-ization of the VM has bitten me here. I'll check it out on
> > the latest from SourceForge. Thanks.
> >
> > Dave
> 
> Yep, that's it.
> 
> A simple fix is to move the declaration of thisSession from sqFilePrims.c
> to sqXWindow.c.

IMO thisSession shouldn't be declared in sqFilePrims.c, because
obviously it isn't file specific.
I don't like the idea to move it to sqXWindow.c though, because this is
Unix specific.

I'd rather vote for moving it into a platform independent file.

 The question for me is, if to move it to
- sqVirtualMachine.c, or
- back into the interpreter, where it was before.

The advantages of the latter are, that we could make it accessible by ST
as standard and ensure that we always generate a new one (at least in
2.9alpha).

Comments?

Stephan

> However, since sqFilePrims.c is one of the common modules
> exported from the image, I don't want to hack it. Therefore, until I think
> of a better approach, you can fix your local sources with the following
> patches:
> 
> ===================================================================
> RCS file: /cvsroot/squeak/Unix_2.8/src/ExternalModules/FilePlugin/sqFilePrims.c,v
> retrieving revision 1.1
> diff -r1.1 sqFilePrims.c
> 47c47
> < int thisSession = 0;
> ---
> > extern int thisSession;
> ===================================================================
> RCS file: /cvsroot/squeak/Unix_2.8/src/sqXWindow.c,v
> retrieving revision 1.3
> diff -r1.3 sqXWindow.c
> 99a100
> > int thisSession = 0;
> ===================================================================
> 
> Dave

-- 
Stephan Rudlof (sr at evolgo.de)
   "Genius doesn't work on an assembly line basis.
    You can't simply say, 'Today I will be brilliant.'"
    -- Kirk, "The Ultimate Computer", stardate 4731.3