[FIX] ContentsChangedTweak

bparsia at email.unc.edu bparsia at email.unc.edu
Sun Oct 14 17:46:36 UTC 2001


The motto of this FIX is "Enhancing Squeak one teeny-tiny nitpick at a
time."

Cheers,
Bijan Parsia.

from preamble:

"Change Set:		ContentsChangedTweak
Date:			14 October 2001
Author:			Bijan Parsia

A message more sent than implemented, its implementation has some minor
minor cruft:
        
Object implements it as
        self changed: #contents  
        
as seems right.

StringHolder *also* implements it as
        self changed: #contents

Which seems...well, not wrong *per se*, but certainly superfluous.
        
CodeHolder implements it as:

        self changed: #contents.
        self changed: #annotation

Which also isn't wrong, and isn't quite superfluous, but certainly seems
to violate abstraction (at least, in the first line).

HtmlEditor (my own thingy) implements it as:
        
        super contentsChanged.
        self changed: #relabel.

Which seems right :)

This change set, which is shorter than this preamble, removes
#contentsChanged from StringHolder, moves it in Object to 'accessing',
and changes it in CodeHolder to use the super version."!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ContentsChangedTweak.cs.gz
Type: application/octet-stream
Size: 3373 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20011014/27222f9d/ContentsChangedTweak.cs.obj


More information about the Squeak-dev mailing list