[BUG][FIX] CommandShell bug in MVC

David T. Lewis lewis at mail.msen.com
Mon Oct 29 00:17:12 UTC 2001


CommandShellV1-3-1-MVC-patch

Fixes a timing problem for CommandShell pipelines running in MVC.
Apply this as an incremental change to CommandShell V1-3.

Symptom: A command line such as '$ ls | edit' or '$ ls | inspect'
did not work in an MVC shell window (Morphic was OK). The editor
or inspector window would open and display an empty string.

Cause: In MVC, the 'edit' and 'inspect' builtin commands scheduled
an editor or inspector window to be opened at a later time using
#addDeferredUIMessage:, and then cheerfully went on to close the
input pipe for the command prior to the deferred action being
executed.

Fix: in a command pipeline, input to the 'edit' and 'inspect'
shell builtin commands is now read completely prior to scheduling
the editor or inspector window and closing the input pipe.

This change set also fixes a harmless but unappealing buglet in
which the last proxy in a command pipeline was sent the #value
message twice.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: CommandShellV1-3-1-MVC-patch.cs.gz
Type: application/x-gunzip
Size: 2138 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20011028/d8a6ad6b/CommandShellV1-3-1-MVC-patch.cs.bin


More information about the Squeak-dev mailing list