Hi, Eddie,

Note that Daniel Vainsencher contributed a speedup for large PluggableListMorphOfMany a year ago, which finally made its way into the internal (3.3a) update stream just this month, but has not yet been externalized.  His focus was on factoring out a loop invariant, and his code modified precisely the same method as yours.

I attach the update here for your inspection -- please compare it with your work and let us know what you find.

Cheers,

 -- Scott


At 3:38 AM -0400 9/13/02, Eddie Cottongim wrote:
>I've noticed that if you "Browse Changes" on a changeset and then select
>many items, the change browser becomes painfully slow while scrolling. The
>following changeset improves this to make scrolling selected items nearly as
>smooth as with nothing selected.
>
>The culprit was PluggableListMorphofMany>>drawOn; the solution should help
>other users of that class, too.
>
>Eddie
>--
>
>"Change Set:  ChangeBrowserSpeedup-efc
>Date:   13 September 2002
>Author:   Eddie Cottongim
>
>When many list items are selected (such as in a change browser) in a
>PluggableListMorphOfMany, scrolling is extremely slow. This speeds up the
>redraw by
>1: removing loop invariants
>2: drawing highlight bars for visible list items only.
>"
>
>	filename="ChangeBrowserSpeedup-efc.1.cs.gz"
>
>Attachment convertedChangeBrowserSpeedup-efc.1.cs.g (????/----) (00087AB1)
-------------- next part --------------
Skipped content of type multipart/appledouble