[FIX] MessageTallyBalloonFix-nk ([er][et] a question)

Daniel Vainsencher danielv at netvision.net.il
Wed Apr 2 07:10:00 UTC 2003


It works. 

A note - Clicking around isn't the indicated test -  the bug is created by balloon 
help on mouseOver.

A question for Ned - the first change seems unrelated to the fix. Do we actually 
have any kind of problem with #ifNil:?

Daniel

Brent Vukmer <bvukmer at blackboard.com> wrote:
> This fix is small, less than 1KB.  The test case for the fix is well-documented.  The preamble does not document the actual changes made for the fix -- however, only 2 lines of code in MessageSet class >> parse:toClassAndSelector: were touched:
> --changed "methodRef ifNil:" to "methodRef isNil ifTrue:"  
> --added "methodRef isEmpty ifTrue: [^ csBlock value: nil value: nil]."
> 
> I re-created the test case that Ned describes by executing the following DoIt and then clicking around in the resulting TimeProfileBrowser:
>   TimeProfileBrowser onBlock: [20 timesRepeat:  [Transcript show: 100 factorial printString]]
> 
> No walkback appeared. I ran SLint on MessageSet; no problems were reported for the [FIX] changes.



More information about the Squeak-dev mailing list