[BUG ][FIX][KCP] Weakness weakness in 3.6alpha ClassBuilder ( [cd][et] very naive fix -- KCP team should review )

Daniel Vainsencher danielv at netvision.net.il
Thu Apr 3 17:17:47 UTC 2003


Have you tried to recompile every class (or have done other basic sanity
tests) to see if it doesn't break anything new?

Daniel

Brent Vukmer <bvukmer at blackboard.com> wrote:
> This is a multi-part message in MIME format.
> 
> --Boundary_(ID_7k+fsLB5f/b4j9QRf2c8Xw)
> Content-type: multipart/alternative;
>  boundary="Boundary_(ID_ld2xc2Vg4tIpkEJdC0DI3w)"
> 
> 
> --Boundary_(ID_ld2xc2Vg4tIpkEJdC0DI3w)
> Content-type: text/plain; charset=Windows-1252
> Content-transfer-encoding: 7BIT
> 
> Re-posted for extra visibility, to the SQFIXES page (http://swiki.gsug.org/sqfixes).
> 
> 
> -----Original Message-----
> From:	Brent Vukmer
> Sent:	Wed 4/2/2003 5:32 PM
> To:	The general-purpose Squeak developers list
> Cc:	
> Subject:	[BUG ] Weakness weakness in 3.6alpha ClassBuilder ( [cd][et]  very naive fix )
> >From the preamble:
> 
> >From Squeak3.6alpha of ''17 March 2003'' [latest update: #5174] on 2 April 2003 at 5:30 pm'!
> "Change Set:		ValidateSubclassFormatFix
> Date:			2 April 2003
> Author:			Brent Vukmer
> 
> Following Tim Rowledge's hint, I put added a little bit of 'typeOfClass' logic to ClassBuilder>>validateSubclassFormat:from:forSuper:extra:.  Actually, I put the logic inside a new method: ClassBuilder>>validateSubclass:canKeepLayoutFrom:forSubclassFormat:.  If the subClass is 'weak' and the superclass is 'variable', then the ClassBuilder should proceed with its bidness. 
> 
> Other changes: 
> --I cleaned up the formatting of validateSubclassFormat:from:forSuper:extra 
> --I got rid of an extra iteration over the collection of subclasses for the 'oldClass'
> 
> Test plan:
> --Open the browser on Array
> --Create a space inside the class definition pane, then delete the space, then hit Alt-s
> 
> 
> 
> 
> --Boundary_(ID_ld2xc2Vg4tIpkEJdC0DI3w)
> Content-type: text/html; charset=Windows-1252
> Content-transfer-encoding: 7BIT
> 
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
> <HTML>
> <HEAD>
> <META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=Windows-1252">
> <META NAME="Generator" CONTENT="MS Exchange Server version 6.0.6249.1">
> <TITLE>[BUG ][FIX][KCP] Weakness weakness in 3.6alpha ClassBuilder ( [cd][et]  very naive fix -- KCP team should review )</TITLE>
> </HEAD>
> <BODY>
> <!-- Converted from text/plain format -->
> 
> <P><FONT SIZE=2>Re-posted for extra visibility, to the SQFIXES page (<A HREF="http://swiki.gsug.org/sqfixes">http://swiki.gsug.org/sqfixes</A>).<BR>
> <BR>
> <BR>
> -----Original Message-----<BR>
> From:&nbsp;&nbsp; Brent Vukmer<BR>
> Sent:&nbsp;&nbsp; Wed 4/2/2003 5:32 PM<BR>
> To:&nbsp;&nbsp;&nbsp;&nbsp; The general-purpose Squeak developers list<BR>
> Cc:&nbsp;&nbsp;&nbsp;&nbsp;<BR>
> Subject:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; [BUG ] Weakness weakness in 3.6alpha ClassBuilder ( [cd][et]&nbsp; very naive fix )<BR>
> &gt;From the preamble:<BR>
> <BR>
> &gt;From Squeak3.6alpha of ''17 March 2003'' [latest update: #5174] on 2 April 2003 at 5:30 pm'!<BR>
> &quot;Change Set:&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ValidateSubclassFormatFix<BR>
> Date:&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 2 April 2003<BR>
> Author: &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Brent Vukmer<BR>
> <BR>
> Following Tim Rowledge's hint, I put added a little bit of 'typeOfClass' logic to ClassBuilder&gt;&gt;validateSubclassFormat:from:forSuper:extra:.&nbsp; Actually, I put the logic inside a new method: ClassBuilder&gt;&gt;validateSubclass:canKeepLayoutFrom:forSubclassFormat:.&nbsp; If the subClass is 'weak' and the superclass is 'variable', then the ClassBuilder should proceed with its bidness.<BR>
> <BR>
> Other changes:<BR>
> --I cleaned up the formatting of validateSubclassFormat:from:forSuper:extra<BR>
> --I got rid of an extra iteration over the collection of subclasses for the 'oldClass'<BR>
> <BR>
> Test plan:<BR>
> --Open the browser on Array<BR>
> --Create a space inside the class definition pane, then delete the space, then hit Alt-s<BR>
> <BR>
> <BR>
> </FONT>
> </P>
> 
> </BODY>
> </HTML>
> 
> --Boundary_(ID_ld2xc2Vg4tIpkEJdC0DI3w)--
> 
> --Boundary_(ID_7k+fsLB5f/b4j9QRf2c8Xw)
> Content-type: application/x-gzip; name=ValidateSubclassFormatFix.1.cs.gz
> Content-transfer-encoding: base64
> Content-disposition: attachment; filename=ValidateSubclassFormatFix.1.cs.gz
> Content-description: ValidateSubclassFormatFix.1.cs.gz
> 
> H4sIAAAAAAAAAKVWTW/bOBA9+6D/MHEOSrCJm88GK6AB3BQGjN0mQB1kD4W7oKWRRYQitSQVN4ug
> v31nKFlWEi822OoSWSTfm3nzZph4Yk0Js79qFPeno/dCVYUAk0McH1/AZ2HTAk6Ojk7jGL4q4dF5
> qKuMXhLYPT++OJuD0XAC48pKFTaC8HCenB5BVcY70fCqEHqJMEOfDAZ3Qkk+O6sXqRLOTYwthZ/I
> 79EnRhwMBn2kaFz7wlj+/NGi9nBX35doo2hilDIrqZdwK0v4YlYKsyXGDgqp/QFMoao9iCzDDAQo
> 6b1CWEgfsvKPFd7kV8wegzJLmYI3EH5/rKXK0F5ePmwNM8lJqCQ3dlZXaBP87q1IRgDj1NdCqcc1
> sS+wBZbayQwpBo0rKJGSyZL/oEpSoX9DrH4Xj6b2k47xWSBEOs0Dj6sXAQ+kg3hFFYxB6KxdoijT
> bvFBWCkWCuMDXtVhSz8UcIWpVQaVNSmScCvpC5DekXCZRudGEEU3dMhCGirqEogOD6eQKhSa9tdV
> gMxDhJ5rQ2q/XcgGbGk8WJnxUaGhWZAerfCSXGYeiJ1JUqo/ps23nDUI4OiYPWyIjcqaEkfRLVu2
> UkInRHFTtakvrFk5giOIsbXikdauLFKoVC1XiRTXxQt8QcUMc6llYK0o5VbHDBX6Zls4134uyG5j
> 5Q/dcCeKop1nSjdOYDESrkuQiFBjcF6UFX1b3D/A2buTd6Gdji+S41PqpFdO6RKH156BtQDw2j3s
> xlvqAogGwy/oa6sdrAoMteU0ZFliJlmKnrKkcwdJdHBPfMEeKpAOCeva8FBoBglkhg5pKqeoKhSW
> e6w0pBX0IgGLKmTuClm50QicgWlcchMFAzlTrjuJYsMR9HUZRtEAhtL9wWyyrJRENvod21z74YAf
> 2rHXRd2uUQtwiyTwdaNfizLfjwYDmU+Ecsjrw6mGJWqyn4IVQiZdamorlmuXQyndIf1NC3QkAD0A
> ex1ob9DAhw9r0feh3Qh9JocqB7SWHdEBaFHiQcxqs44LJLlSU1aShl08CigB6BvkDAPzOX38Bt7W
> uAM7P++5X7d47qWD8i1e45bmDeGt6eHwe6qdn8m/kZyyvgaC3XbZW9RsnsrjuunVKmy6MdcakXR+
> 4p7zgrHgKRp07Cwy3RwyvyUJSNVGi/kIyJnPEYZXpGP9kv+B+TXNPppmPEhopj8/tqH9s58Qyb5x
> GZXqWqrGSG0c/WOb98ONbG3y11RvB44WuZJ7nYRvhvxlI7tsY5tvCa61f/e1d1E0G+bBpG+Pv3/T
> bOVtKsMZbKoDexusSzg5P9tvLL3Z0G+K+LOxXC6aPLQ10AhNQ3p9q7lNR7T9MB9F6/5obBD1rMKX
> 21ipWVfdT4YYE6o2PFEPc9m7VEjWF5HC/prr3wNmhLaBC+Fo9r0tfBi8yqLHNaRbnwbREvmfDLrU
> c2EP6DrG9P6nB/hoGMHzp+XcW/f6jx+wq7krVTvDtue/9Zr6vzfUPOTfG2r/AM/KPBetCgAA
> 
> --Boundary_(ID_7k+fsLB5f/b4j9QRf2c8Xw)
> Content-type: text/plain; name=ATT849570.txt
> Content-transfer-encoding: 7BIT
> Content-disposition: attachment; filename=ATT849570.txt
> Content-description: ATT849570.txt
> 
> 
> 
> --Boundary_(ID_7k+fsLB5f/b4j9QRf2c8Xw)
> MIME-version: 1.0
> Content-type: text/plain; charset=us-ascii
> Content-transfer-encoding: 7BIT
> 
> 
> 
> --Boundary_(ID_7k+fsLB5f/b4j9QRf2c8Xw)--



More information about the Squeak-dev mailing list