[BUG]Assorted SUnit base image tests fail in 3.6

Tim Rowledge tim at sumeru.stanford.edu
Sat Aug 16 03:28:35 UTC 2003


3.6 #5387 image.
Run 'BaseImage Tests #12'

Many failures, quite a few testClassComment & testUnCategorizedMethods
but also some serious functional errors.

FileDirectoryTest>testExists was checking completely the wrong directory
in the final assert. Fixed. (Still fails on unix becase of vm caching
the directory entry (?))

TestsForTextAndTextStreams>testReplacement1 was failing because (I
claim) Text>replaceFrom:to:with:startingAt: was simply messing up the
runs array by inserting the entire replacement's runs into thereceiver's
runs. Fixed - I think.

BitBltTest>testAlphaCompositing[2]Simulated failed becase the use of
at:ifPresent: was plain wrong - the block required a single argument.
Fixed.

TestForTextAndTextStreams>testExampleText2 fails because Text cannot be
reversed correctly - there is no implementation of #reversed for Text
and the SequencableCollection version is unsuitable.  #testExampleText1
fails for similar reasons; growing the collection of a TextStream is not
done even vaguely properly.

BitmapStreamTests>testShortPointArrayWithSmartRefStreamOnDisk fails
because an array of a at b c at d etc gets read back as b at a d at c etc :-)
#testShortRunArrayWithSmartRefStreamOnDisk does the same. PRoblem with
writing or reading SmartRefStreams?

BCCMTest>test06bClassDescriptionAllSubInstances fails because it is
plain weird.

ExceptionTests>testSimpleOuter fails. Didn't somebody recently mess with
Exceptions and #outer? Ah, yes, 5308ContextEnh-ajh.

ByteArrayBugz>testByteArrayLongAt fails because it attempts to put -1 in
a ByteArray. It works ok for +ve numbers.

BitmapBugz>testBitmapByteAt fails because Bitmap>byteAt:put: fails to
ensure the input value is actually a byte (and happily screws up the
answer). Potential fix is to mask the value, another possibility is to
raise an error. From the look of the SUnit it seems that raising an
error is anticipated but somebody else should consider what was wanted.

BitmapStreamTests>testShortIntegerArrayWithRefStream fails with an error
in RWBinaryOrTextStream>nextWordsInto: because ShortIntegerArray doesn't
understand bytesPerElement. Looks to me as if ShortIntgerArray
ought to override newFromStream: ? Similar problems with
testShortIntegerArrayWithSmartRefStream et al.




tim
--
Tim Rowledge, tim at sumeru.stanford.edu, http://sumeru.stanford.edu/tim
Strange OpCodes: SM: Sear Memory
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TestFixesTPR.1.cs
Type: application/octet-stream
Size: 2876 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030815/c8361834/TestFixesTPR.1.obj


More information about the Squeak-dev mailing list