Ok, I reviewed the four changesets, and they look good to me.  I assume 
we're talking about KCP 98-101 which you posted a few days ago.

I agree that changing the standard usage to "self systemNavigation ..." 
is the best way to go... we won't have "SystemNavigation new" or 
"SystemNavigation default" hardcoded everywhere, which would make it 
more difficult for someone to plug in their own system navigation tools 
for example.

Even though we are in beta and this is an API change, I think it's 
reasonably safe for 3.6 for two reasons:  1. The SystemNavigation stuff 
was introduced during 3.6alpha, so we're not changing the API from 3.5 
to 3.6 anymore than it's already been changed.  2. The API is really 
being added to, not changed, anyway.  If an external package still uses 
"SystemNavigation new" it will still work, although "self 
systemNavigation" should be the preferred way.

I will approve these and incorporate them today/tomorrow.

- Doug


Stephane Ducasse wrote:

> But we code it together with daniel. That's why he cannot harvest it :)
>
> On Monday, August 25, 2003, at 08:33 PM, Doug Way wrote:
>
>>
>> Stephane Ducasse wrote:
>>
>>> Doug and other
>>>
>>> please have a look at the KCP submissions related to 
>>> systemNavigation this is important that
>>> they are in 3.6 so that 3,7 will not undeprecate certain methods. 
>>> This way the sotry around
>>> systemNavigation can be closed (even if after we will have to clean 
>>> systemNavigation because we just move the code there and this is 
>>> often not consistent).
>>
>>
>>
>> I don't have a lot of extra time myself for harvesting individual 
>> items, since I am already handling the incorporation of items into 
>> the update stream (which takes a bit of time).  But Daniel has been 
>> looking at this stuff in the past, so perhaps he (or someone else) 
>> can give them a quick review and approve the appropriate items for 
>> 3.6?  Obviously we don't want any new enhancements or major 
>> refactorings in 3.6, just bug fixes.
>
>
> There is no major enhancements. Just fixing the deprecated method in 
> classDescription, changing SystemNavigation to be a singleton, 
> introducing one method in Object to remove duplicated code.
>
> Ned do you have the time to look at what we did. Else we will have 
> changes again in 3.7 and this
> is stupid to change the public interface again.
>
>> Regarding my incorporating duties, on the bright side I've created an 
>> UpdateIncorporationTool which works with the BFAV and has automated 
>> some of the tasks... I used it for the last batch of updates.  I'll 
>> post it on SqueakMap soon.  (Not that anyone else will need it right 
>> now, but perhaps in the future.  And of course it doesn't include the 
>> password for write access to the updates server. :-) )
>>
>> Speaking of 3.6, we've just passed the date we tentatively set for 
>> moving 3.6 from beta to gamma.  Things seem to be getting a bit more 
>> stable now with 3.6beta, but we should probably have at least one 
>> last round of bug fixes before moving to gamma.  Maybe we should 
>> shoot for this Friday for the move to gamma?  Also, creating a gamma 
>> image this time will mean I need to put together a Full release 
>> candidate image in addition to the Basic release, so it'll be a 
>> little extra work.
>>
>> - Doug
>>
>>
>>
>