[BUG][FIX] CondenseSources uses wrong file name [sm]

ducasse ducasse at iam.unibe.ch
Sat Dec 6 11:59:14 UTC 2003


On Samedi, déc 6, 2003, at 00:30 Europe/Zurich, Boris Gaertner wrote:

> ducasse <ducasse at iam.unibe.ch> wrote:
>
>
>> Hi Boris
>>
>> could you resubmit your fixes once the pending approved items are put
>> in the stream because
>> one KCP element is changing the image name and the rest.
>>
>> Thanks
> Now that change set 5567 (KCP110ChangesFromSTim) is in
> the update stream I can do that.
> Attached you find two proposals:
>
> A small one that changes only what needs to be changed to
> make condenseSources work again, and a larger one that
> removes  SourceFileVersionString  from  SystemDictionary.

Excellent this is what is needed.

>
> The minimal changes are in  CondenseSources.4.cs.
> CondenseSourcesL.3.cs is the larger change, which removes
> the class variable. The changes sets are independent from
> each other, we are free to choose what we prefer.
> Personally I prefer the more complete change, because I think
> it is never a good solution to store a piece of information
> at two places.
Exact this was just temporary while moving stuff from systemDict to 
SmalltalkImage

>
> Both change sets are based on change set 5567 and
> can be used without loosing the features of  5567.
>
> This change touches the KCP project, opinions from the
> KCP contributors are most welcome.

I will look at that believe me :)
>
>
> Greetings,
> Boris
>
> Description of the problem (From a previous mail):
>
>>
>> On Mercredi, nov 26, 2003, at 17:09 Europe/Zurich, Boris Gaertner 
>> wrote:
>>
>>> This bug report is for Squeak 3.7alfa, latest update: #5566
>>>
>>> from the preamble:
>>>
>>> Smalltalk condenseSources runs into an error that is caused by the
>>> fact,
>>> that
>>> the SourceFileVersionString is stored at two places - in
>>> SystemDictionary
>>> and in SmalltalkImage. When we get a new file name from the prompter,
>>> we have to update the string in both classes. This is added in
>>> SystemDictionary>>condenseSources.
> <CondenseSources.4.cs><CondenseSourcesL.3.cs>




More information about the Squeak-dev mailing list