Doug,

This isn't for me to decide. Of course, *I* think that it works, but I
thought so before and I was wrong ;-( I'll (happily ;) leave this decision
to the guides.

Cheers,
  - Andreas

> -----Original Message-----
> From: Doug Way [mailto:dway at riskmetrics.com] 
> Sent: Friday, February 28, 2003 1:07 AM
> To: The general-purpose Squeak developers list; Andreas Raab
> Subject: Re: [FIX] ClassBuilder problem
> 
> 
> 
> A general question:  Do you think this fix looks reasonably 
> safe enough to
> include with 3.4gamma?  I was going to finalize 3.4 by 
> tomorrow, but if we add
> this, we would need to postpone the release by a few days at 
> least to test
> this a bit.  On the other hand, this is a sort-of important 
> fix which may be
> worth delaying 3.4 by a few days.
> 
> If we added this, I would probably create a quickie 
> 3.4gammaTwo, and I would
> encourage people to do some class-rebuilding related testing on it. 
> 
> - Doug Way
> 
> 
> Andreas Raab wrote:
> > 
> > Okay, restating the problem actually helped me to 
> understand how to fix it.
> > 
> > "Change Set:            MetaClassBuilderFix
> > Date:                   27 February 2003
> > Author:                 Andreas Raab
> > 
> > This change set fixes a rather obscure bug with reshaping 
> the entire class
> > hierarchy from ClassBuilder. The problem was introduced by 
> accidentally
> > breaking the superclass/subclass invariant. The CS fixes 
> this problem, by
> > doing so actually removes some code and documents the 
> critical invariants
> > (both by putting comments into the methods affected and by 
> making those
> > methods private which temporarily break the crucial invariants).
> > 
> > The class comment has been extended to document the 
> fundamental assumption
> > that ClassBuilder needs access to ALL of the subclasses no 
> matter where no
> > matter how they are created.
> > "
> > 
> >   
> --------------------------------------------------------------
> ----------------
> >                                 Name: MetaClassBuilderFix.cs.gz
> >    MetaClassBuilderFix.cs.gz    Type: ChangeSet 
> (application/x-unknown-content-type-cs_auto_file)
> >                             Encoding: base64
> > 
> >   
> --------------------------------------------------------------
> ----------------
>