RV: [FIX] ClassCommentVersionsBrowser fix

Magistrello Alejandro (SFA) magistra at TELEFONICA.COM.AR
Fri Jan 3 19:33:37 UTC 2003


oops ...

i wanted to sent this to the list also ;-)

> -----Mensaje original-----
> De:	Magistrello Alejandro (SFA) 
> Enviado el:	viernes 3 de enero de 2003 16:20
> Para:	'Scott Wallace'
> Asunto:	RE: [FIX] ClassCommentVersionsBrowser fix
> 
> 
> Hi Scott and all,
> 
> it seems that i only saw a tree while you a lot more ;-)
> 
> just a small thing,
> 
> In a image without a condenseChanges, modify the classComment for
> ProcessBrowser
> 
> With your version in the ccvb you'll see
> 'new_stamp ProcessBrowser class comment'
> 'new_stamp ProcessBrowser class comment'
> 
> With the version i sent you'll see
> 'new_stamp ProcessBrowser class comment'
> '<historical> ProcessBrowser class comment'
> 
> after a condenseChanges your version will do the same.
> 
> The attached is your cs with this little change.
> 
> best regards
> Alejandro Magistrello
> 
>  <<commentInCompressChgs-sw.cs.gz>> 
> 
> -----Mensaje original-----
> De:	Scott Wallace [SMTP:scott.wallace at squeakland.org]
> Enviado el:	viernes 3 de enero de 2003 3:52
> Para:	squeak-dev at lists.squeakfoundation.org
> CC:	Magistrello Alejandro (SFA)
> Asunto:	Re: [FIX] ClassCommentVersionsBrowser fix
> 
> Actually, the real bug here is that class-comment-authoring-stamps have
> not ever been preserved in the changes log when a condenseChanges is done.
> So that's what really needs to be fixed ;-)
> 
> I attach for consideration a change-set that purports to fix it.
> 
> Alejandro, I *think* that this should actually also serve to resurrect the
> "lost" class-comment-authoring-stamps in your image in which you'd already
> done a condense-changes, provided you simply perform another
> condenseChanges on it after filing the fix in.
> 
> Since building 3.4-gamma and 3.4-final will involve condensing changes,
> and since we want to preserve the existing comment stamps, I would like to
> have this code in 3.4.
> 
> But I'd appreciate hearing of others' experiences with this fileout before
> publishing it.  Thanks ;-)
> 
> Cheers,
> 
>   -- Scott
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: commentInCompressChgs-sw.cs.gz
Type: application/octet-stream
Size: 2464 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030103/d75b91e1/commentInCompressChgs-sw.cs.obj


More information about the Squeak-dev mailing list