[KCP] SystemDictionary cleaning: Comments and design

Scott Wallace scott.wallace at squeakland.org
Thu Jun 12 08:06:30 UTC 2003


>The comment in the method is not only badly spelled, it says # when
>it means @.  I don't know who 'sw' is, but the method went in on
>2002.06.10

I don't know who he is either, but I agree he should be shot.

FWIW, here's the comment in question, complete with the two typos ;-)

pointOrNilFrom: aString
"Lightly parse aString, looking for either of two syntaxes -- 
integers separated either by a # character or by a comma, as 
illutrated by the following, which are equivalent:
		2 @ 3
		2 , 3
If the input fits one of these patterns, return the Point object 
represented; anything else will result in nil being returned."


Incidentally, for those who may not know, a good way to discover the 
history and the context of any method that you wish to delve into is 
to look at the change-sets in which it occurs.  To do this, choose 
"change sets with this method" from the shifted selector-list menu of 
a code tool that is pointed at the method.

If you do this for Utilities.pointOrNilFrom:, you'll immediately get 
a change-sorter pointed at this method's originating change-set, with 
the "preamble" showing.  This will reveal who wrote the code, and 
when, and why, and will show all the methods involved, and there's 
also a remark there about a desired improvement.

Cheers,

   -- Scott

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030612/5816cf40/attachment.htm


More information about the Squeak-dev mailing list