[ENH] isSymbol [small] ( [approved] )
Nevin Pratt
nevin at smalltalkpro.com
Mon Jun 23 12:46:19 UTC 2003
I assume that the two methods are Object>>isSymbol (to return false),
and Symbol>>isSymbol (to return true).
Glorp also needs these, and so the Squeak Glorp package adds them. In a
private email to Alan Knight (the Glorp guy on VisualWorks), I told him
that in my opinion, they should have been put in the base package of Squeak.
In other words, I agree that these changes should be approved.
Nevin
marcus at ira.uka.de wrote:
>No, this isn't nice. I don't think that approving my own changes is a
>good Idea.
>But: This is a trivial change, 2 methods, with a total of 2 lines of
>code, forming
>a well known pattern. I wrote lots of more lines why this is good, this
>code
>is needed to run *any* parser written with SMACC if you don't install
>the
>developers package, .... What I want to say: We have a HUGE Problem
>with
>reviewing and Harvesting changes. If we don't fix this, than Squeak will
>die. It's
>as simple as that.
>
> Marcus
>
>
>< I'm a bug-fixing machine! >
>
>This post brought to you by the BugFixArchiveViewer, a handy tool that
>makes it easy to comment on proposed fixes and enhancements for Squeak.
>For more information, check out the Web page for the BugFixArchiveViewer
>project: http://minnow.cc.gatech.edu/squeak/3214
>
>< I'm a bug-fixing machine! >
>
>
>
>
--
Nevin Pratt
Bountiful Baby
http://www.bountifulbaby.com
(801) 992-3137
More information about the Squeak-dev
mailing list
|