[FIX] MethodReferenceHashFix-dgd (CD, ER, SM, SL, ET - dvf - needs rework)

Daniel Vainsencher danielv at netvision.net.il
Sat Mar 8 02:08:19 UTC 2003


A few comments I have -
1. I think it's usually better to separate tests out more into separate
methods, using setUp to create the required common fixtures (commonly
used values, held in instance variables). That way it's more obvious
what is broken, and it's better documentation of the intention of the
test.
2. #hash is strangely formatted.
3. It's probably better if people separate the Test changeset from the
fix changeset. This makes a few things easier - 
* we can load the test before the fix, to see it break, and then load
the fix.
* they can easily be harvested separately (test now - fix after rework,
or test into test package - fix into update).

Note that the fix works just fine, came with a test, and is simple -
it's generally very good, needs just a little polish. Most of the reason
it's rejected is that it's important to raise our awareness of what
makes work for the harvesters, so that future stuff is nearer perfect.

Thanks, Diego.
Daniel

diegogomezdeck at consultar.com wrote:
> 
> --Boundary_(ID_9xQQ87mv0sL9cqfNP+0pRg)
> Content-type: text/plain; charset=iso-8859-1
> Content-transfer-encoding: 7BIT
> 
> Change Set:		MethodReferenceHashFix-dgd
> Date:			7 March 2003
> Author:			Diego Gomez Deck <DiegoGomezDeck at ConsultAr.com>
> 
> Method MethodReferenceTest>>= is implemented but MethodReferenceTest>>hash
> isn't
> 
> - MethodReferenceTest>>testEqualsAndHash  test that shows the error (and
> probe the fix)
> - remove MethodReferenceTest>>species (it's not necesary becouse of
> Object>>species)
> 
> 
> 
> --Boundary_(ID_9xQQ87mv0sL9cqfNP+0pRg)
> Content-type: application/x-gzip-compressed;
>  name=MethodReferenceHashFix-dgd.1.cs.gz
> Content-transfer-encoding: base64
> Content-disposition: attachment; filename=MethodReferenceHashFix-dgd.1.cs.gz
> 
> H4sIAAAAAAAAAM1VTU8bMRA978H/YRIOGw4EQlKligpqmpSWA61EUFUJpZV3d5J12bUX20tIxY/v
> 2KElH5sCbQ89RFqP38x43puZhCda5TC6LpFftZsdUBNowRnXcQqHBwdtuMy4RWOhLBL66MHOi1b3
> YAxKQncZxi20eu1Or9WFIg9rrD5IuZwijND2guAMbaqSc5ygRhnje27SE3G7l0wTNnRRgyBYjsb6
> JeG1Mw8FThW8Uzl+hyHGV/DKW7zBnV8PlDRlZvu6Gav8mLFFKljLeEElHB8fgTAg8iLDHKXFBKLS
> ViNTeiGBZWgZ26uGOFbeXpc8M32ZuIoAPFE2JS5MqmaGPhFQa6WhwWUChVYReuNE3O5SXI25usHq
> 8KbAWKCBhrChAaksSIzRcD2HCGNVGnRSfYy+YfyA3mX1GmMuwIATwJRRnHFjSLWKHCwQ0lhOp09c
> Cx5l+IHnSOAwZIH3q7AXSmVDEVuhJF3+QpOIU6XndLoggNl7o6l+1NQIrLaWGnJ/NickMIQkWkGB
> DKkYAr0mL8hIfQHt/e6+76xWu9d6SYGOgBMLKer1eCyo96WZoYZZig7gKdbElrihg2PeGbielk52
> uik0GvflzCwwVB0oT2SzzoIvYDCbwE/+j7bmvUewIKAUPbj0bp630TyPVAZbPZdA4wr3U0MO/BH3
> BWjNfUHtY+mXUeMa/BuNDlukkRubBzk4jHKeZac0alOvjqKevOFZiW4ONbrNQtqoFb2o2UkTkZA+
> ws4XgjQaK5L44YyE/exet8G6u90lWtxvBbRCjkP50jdqd6OxWv95KaWQ09/U3qHaN/YBC+6ArxO7
> RZI7FmxAv64vBtoAsyYBq0Nsg7vaiQraSGXmGmUjz7Y+GT/F2WuxtdPcrQtTr1fUZ9COaP0kXCeD
> xZYaWU08rwhFq2ui1Paqnxfkv+HimcX4/n5CSdI+t6g/ec3aOyKu//IdfhCrxnDxBznCjHazG8Wd
> hyGrPd3BDeMGfBN6v15q7AfaivNjEwkAAA==
> 
> --Boundary_(ID_9xQQ87mv0sL9cqfNP+0pRg)
> MIME-version: 1.0
> Content-type: text/plain; charset=us-ascii
> Content-transfer-encoding: 7BIT
> 
> 
> 
> --Boundary_(ID_9xQQ87mv0sL9cqfNP+0pRg)--



More information about the Squeak-dev mailing list