While we're talking about the QA tags, I'd like to be able to see on the sqfixes page when a fix/enh has been Harvested, and when it becomes an Update.
Are those reasonable features?

If implemented, here's what that might look like on the sqfixes page, using the HumptyDumpty example from http://minnow.cc.gatech.edu/squeak/398:

[FIX] Glue HumptyMorph Back Together Again ( [cd] bkv )
   Joshua 'Schwa' Gargus (3/7/03 ) ( [er][et] Great work!  I can't believe that he's fixed )
   Daniel Vainsencher (3/9/03 ) ( [sm][er][et] Try again -- no SLint, no SUnit tests )
   Brent Vukmer (3/10/03) ( [sl][su] 3 tests, all green )
   Daniel Vainsencher (3/9/03 ) ( [sm][er][et] Approved )
   Doug Way (3/12/03) ( [HARVESTED] comments still welcome )
   Dan Ingalls (3/11/03) ( [er][et][su] minor fix + 2 tests for EggMorph )
   Doug Way (3/12/03) ( [UPDATE]8389-HumptyMorph-bkv )



-----Original Message-----
From:	Brent Vukmer on behalf of Brent Vukmer
Sent:	Sat 3/8/2003 12:15 PM
To:	The general-purpose Squeak developers list
Cc:	
Subject:	RE: Process, harvesting, getting your favorite things in the image
I really like the suggestion of a [su] tag for posts that include SUnit tests.

If the submitted changeset passes relevant existing SUnit tests, I think that [et] ("Externally Tested") tag is fine.


-----Original Message-----
From:	Joshua 'Schwa' Gargus [mailto:schwa at cc.gatech.edu]
Sent:	Sat 3/8/2003 10:00 AM
To:	The general-purpose Squeak developers list
Cc:	
Subject:	Re: Process, harvesting, getting your favorite things in the image
On Sat, Mar 08, 2003 at 12:13:39PM +0300, Daniel Vainsencher wrote:
 

What about an [su] tag if SUnit tests are included or if the changeset
passes relevant existing SUnit tests?

> 
> Of course, the SLint tool is on SM, just install the RefactoringBrowser,
> and type LintDialog open (hmm, should add it to the open menu). Check it
> out!

Will do.

Joshua


> 
> Daniel
> 
> Joshua 'Schwa' Gargus <schwa at cc.gatech.edu> wrote:
> > It appears that the [et], [er] comment tags have to be within the
> > comment parentheses (since a post by Tim with the comment tags
> > preceding the parentheses didn't make it through).  The documentation
> > on the swiki doesn't reflect this.
> > 
> > Is this be the desired behavior?  It seems reasonable to me; I'll make
> > the appropriate change to the swiki documentation.
> > 
> > This all very exciting!  Thanks to everyone involved in harvesting,
> > refactoring, packaging, etc.
> > 
> > Joshua
> > 
> > 
> > On Sat, Mar 08, 2003 at 01:31:01AM -0500, Doug Way wrote:
> > > 
> > > On Friday, March 7, 2003, at 12:35 PM, Jesse Welton wrote:
> > > 
> > > > Brent Vukmer wrote:
> > > >>
> > > >> Cool feature!  One minor thing: the tags *read* a little weird.
> > > >> "et, er - it's beautiful" sounds like someone stuttering :)
> > > >> Also the tags look kind of like 'Who is Who' nicknames.  Could we
> > > >> put fix tags in some kind of brackets?
> > > >
> > > >> [Fix] Adjust the background to a paler shade of gray
> > > >>   Jane Doe (2/3/4)
> > > >>   Joe Shmoe (5/3/4) (<et><er> - it's beautiful)
> > > >
> > > > I'll second that.  This way reads alot more clearly for me, as well.
> > > 
> > > I see that Brent (or somebody) ended up using square brackets in the 
> > > swiki page docs, which I probably like the most.  Like this:
> > > 
> > >    [FIX] Adjust the background to a paler shade of gray
> > >      Jane Doe (2/3/03)
> > >      Joe Shmoe (5/3/03) ([et][er] - it's beautiful)
> > > 
> > > http://minnow.cc.gatech.edu/squeak/398
> > > 
> > > But we don't have to be too rigid about this, as long as they're not 
> > > parentheses, which apparently messes up the sqfixes parser. :-)
> > > 
> > > - Doug Way
> > >





-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/ms-tnef
Size: 4663 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030308/fa6eb820/attachment.bin