[FIX] Re: Preferences class usage question

Scott Wallace scott.wallace at squeakland.org
Fri May 16 07:48:17 UTC 2003


Hi, Stephane, and all,

Okay, I've made a careful pass through all the entries in the 
Parameters dictionary in a standard image, and found that all but 
*three* of the entries are legitimate and in active current use.

The three superfluous entries are the two mentioned earlier, 
#Prevailing and #PersonalPreferences, plus a third item, 
#systemLanguage, which formerly was a system-wide parameter, but is 
now separately maintained for each individual project, and hence now 
stored as a project-parameter instead of a system-wide parameter.

The attached change-set, which subsumes the earlier fix, removes all 
three of the superfluous entries in Parameters.

It was very helpful in tracking these down to have a command in the 
menu of the key-list-pane of a dictionary inspector for querying 
"senders of this key" whenever the key is a symbol, so this 
change-set adds that, as well as adding a stay-up item for the menu.

Cheers,

   -- Scott


At 8:03 AM +0200 5/16/03, Stephane Ducasse wrote:
>Scott
>
>could you propose a clean that we could review and incorporate?
>Thanks
>
>
>On Thursday, May 15, 2003, at 11:19 PM, Scott Wallace wrote:
>
>>Hi, Anthony,
>>
>>The entry in Parameters under key #Prevailing is a leftover from a 
>>transition in Preferences architecture a couple of years ago, which 
>>has hung around in the image unnoticed.  It, and the Parameters 
>>entry under #PersonalPreferences as well, can and should be removed.
>>
>>The attached change-set does this.
>>
>>As part of the broad cleanup of Squeak underway, it will good for 
>>the Parameters to undergo a careful scrutiny.
>>
>>Cheers,
>>
>>   -- Scott
>>
>>
>>At 12:39 PM -0700 5/15/03, Anthony Adachi wrote:
>>>Hello
>>>
>>>I was inspecting the Preferences class and came across
>>>something I don't understand.
>>>
>>>Why are some preferences in the Preferences class
>>>stored in two different class variables?
>>>
>>>For instance, #honorDesktopCmdKeys is located in both
>>>the class variables:
>>>
>>>1. DictionaryOfPreferences (as an instance of the
>>>class Preference)
>>>
>>>2. Parameters (under #Prevailing as a Boolean).
>>
>><expungeParameter-sw.cs.gz>
-------------- next part --------------
Skipped content of type multipart/appledouble


More information about the Squeak-dev mailing list