On Thu, Nov 27, 2003 at 08:27:36PM -0800, John M McIntosh wrote:
> I'm proposing a change to sq.h such that
> 
> /* image file and VM path names */
> 
> extern char imageName[]
> 
> becomes
> 
> char *imageName(void);

This sounds like a good thing to do.

A quick grep shows that the following files have references to imageName[].
Some redeclare it after having already included sq.h.  I don't think this
hurts anything, but it suggests that it might take a while to tidy things
up after making the initial change.

  ./Cross/vm/sq.h
  ./Mac OS/vm/Developer/sqMacMinimal.c
  ./Mac OS/vm/sqMacImageIO.c
  ./Mac OS/vm/sqMacMain.c
  ./Mac OS/vm/sqMacNSPlugin.c
  ./Mac OS/vm/sqMacUIAppleEvents.c
  ./RiscOS/vm/sqArgument.c
  ./RiscOS/vm/sqArguments.h
  ./RiscOS/vm/sqRPCMain.c
  ./RiscOS/vm/sqRPCWindows.c
  ./unix/npsqueak/npsqueak.c
  ./unix/plugins/SecurityPlugin/sqUnixSecurity.c
  ./unix/vm/SqDisplay.h
  ./unix/vm/sqUnixMain.c
  ./unix/vm-display-X11/sqUnixX11.c
  ./unix/vm-display-fbdev/sqUnixFBDev.c
  ./unix/vm-display-null/sqUnixDisplayNull.c
  ./win32/vm/sqWin32.h
  ./win32/vm/sqWin32Args.c
  ./win32/vm/sqWin32Args.h
  ./win32/vm/sqWin32Intel.c
  ./win32/vm/sqWin32Prefs.c
  ./win32/vm/sqWin32Service.c
  ./win32/vm/sqWin32Window.c

To ease any transition pains, I would suggest retaining the old declaration
in sq.h for a year or so, and make the immediate change to sq.h look something
like this:

  /* image file and VM path names */
  char *imageName(void);   /* JMM December 2003 */
  extern char imageName[]; /* deprecated, use imageName() instead */

Dave