[FIX] ClassVarsFix-petervr (was: Shared variables binding/lookupbug)

Anthony Hannan ajh18 at cornell.edu
Sat Oct 11 18:46:54 UTC 2003


"Peter van Rooijen" <squeak at vanrooijen.com> wrote:
> From: "Anthony Hannan" <ajh18 at cornell.edu>
> > but he also changed Class>>declare: to no longer raise a notifier
> > when filing-in a class var that shadows another var.
> 
> Defining a class variable that shadows another var is neither an error nor
> something that needs to be debugged, so I don't see the reason for sending
> self error:, *at all*.

I would still like to see a notifier because I don't think it is not
good style to shadow a global var.  You can just change error: to
notify:.

> Also consider that if I install a program with 273 class variables that each
> have a reasonable chance of shadowing an existing global (or a pool
> variable, for that matter), I should not be required to press 'proceed'
> hundreds of times to install it. Or am I missing something?

I would enhance the notifier mechanism to allow "proceed for all".

Cheers,
Anthony



More information about the Squeak-dev mailing list