[ENH] RBRelatedPatches [sm]

Andreas Raab andreas.raab at gmx.de
Tue Sep 16 23:02:06 UTC 2003


> These are a few very small changes that the RB currently makes, that I
> think should be included in the image.
> 
> 1. Dictionary>>associations returns the collection of associations.

+1: A generally useful method.

> 2. SharedPool class>>keys - to restore a bit more compatibility with
> Dictionaries.

-1: SharedPool deliberately doesn't use dictionary protocols. There is no
reason to start migrating the entire dictionary protocol over to it. The
clients ought to know that they're dealing with pools instead of
dictionaries.

> 3. Text>>withSqueakLineEndings implementation, by Ned. Not perfect, 
> according to him.

-10: It's broken. The invariant of Text is that "strings size = runs size"
and the method does not preserve that invariant.

> 4. Collection>>ifEmpty:ifNotEmpty: and variations.

-1: This should not be sneaked in as a "small change" given that it
significantly extends the collection protocol. And is questionable in the
semantics - the asymmetry between #ifEmpty: (0-arg block) and #ifNotEmpty:
(1-arg block) greatly disturbs me.

> 5. Symbol class>>findInterned:aString

+1: Simple enough and reasonable.

Cheers,
  - Andreas



More information about the Squeak-dev mailing list