[FIX] ClassRemovalRename (V2: merged changesets)
marcus at ira.uka.de
marcus at ira.uka.de
Tue Sep 30 16:38:01 UTC 2003
from preamble:
"Change Set: ClassBindingRemovalRenameV2
Date: 15 September 2003
Author: Daniel Vainsencher and David T. Lewis
SystemDictionary>>removeClassFromSystem:logged: should be called only
Class removeFromSystem, and has been used erronously. This changeset
renames it to forgetClass:logged:, which I hope reveals the intention of
removing a class from various lists, and is less likely to be
misunderstood. The old method is deprecated documenting the proper way
to do things.
md: merged with changeset ClassRemovalRename-edits-dtl
Date: 16 September 2003
Author: David T. Lewis
Minor edits to the ClassBindingRemovalRename change set by Daniel
Vainsencher, 15 September 2003.
Sorry I have not figured out the BFAV yet, so I'm sending my
comments in a change set.
Class>>removeFromSystem has unnecessary formatting changes.
Should be a one-word change to the method. Changed it back so
that the only thing that changes is the call to #forgetClass:logged:.
Fixed typo in the comment for
SystemDictionary>>removeClassFromSystem:logged:
(s/SsytemDictionary/SystemDictionary/).
I think that #forgetClass:logged: is a good choice for the method
name. It conveys the intent of the method without setting incorrect
expectations.
In most cases, I would not expect that the deprecated method should
have its behavior changed, but think the way it is being done here
makes a reasonable choice on behalf of the user, so let's go with it.
- Dave "!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ClassRemovalRenameV2.cs.gz
Type: application/octet-stream
Size: 1546 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030930/5e3c5ce9/ClassRemovalRenameV2.cs.obj
More information about the Squeak-dev
mailing list
|