On Sun, Apr 11, 2004 at 04:20:02PM +0200, Ian Piumarta wrote:
> > 	From: 	  alangrimes at starpower.net
> > 	Subject: 	[FIX] perennial unix build problem...
> > 	Date: 	09 April 2004 02:15:55 CEST
> >
> > Every flaming time, for the last year and a half now, that I fully 
> > synchronized my sources with  the CVS, I've had to edit this file!!
> >
> > 		  $(LDFLAGS) $(XLDFLAGS) -export-dynamic -R$(libdir) $(X_LIBS) -o
> 
> On 11 Apr 2004, at 15:31, bryce at kampjes.demon.co.uk wrote:
> > I'm assuming you're talking about adding $(X_LIBS) to the link line.
> >
> > If so and it means that Squeak will build without having to add extra
> > sym-links to get it to compile cleanly then my vote is we should add 
> > it.
> 
> I hereby offer a free beer to the first person who can explain 
> correctly why adding the above to the link line is COMPLETELY AND 
> UTTERLY THE WRONG THING TO DO.  (Which it most definitely is. ;)

Well, this is unlikely to be a completely correct explanation, but
the answer would go something like this:

The snippet of file in Alan Grimes' request for a fix is from the
Makefile.  The Makefile is a derived file, built from various sources
in the platforms/unix/config directory. Patching the Makefile does
not fix anything permanently, as it gets clobbered by the configure
script.  Furthermore, the Makefile *should* be different on different
platforms (that is what autoconf is for), so it should not be maintained
as a "source file" in the Unix platforms sources.

The value of X_LIBS in the Makefile is generated by a line in
platforms/unix/config/make.cfg.in, but this should not be modified
either, since it merely passes through the value of @X_LIBS@, which
presumably is a variable set by the configure process, although I
have no idea how that part works.

In any case, the root cause of the problem that Alan reports has
nothing to do with the Makefile, and presumably needs to be addressed
by something in the autoconf process.

Dave