[KCP][FIX] KCP-0220-ClassOrganizerFixAndCleanup.8.cs

stéphane ducasse ducasse at iam.unibe.ch
Thu Apr 15 14:29:37 UTC 2004


You meant 3.7 :). Doug mentioned that it will be for 3.7.
I think that this is important that the system notification contains as 
few bugs as possible. Because
people working with non-alpha version should get something stable



On 15 avr. 04, at 16:01, Nathanael Schärli wrote:

> Hi Doug, Stef, and Marcus
>
>> Doug wrote:
>>
>> I agree that it definitely looks like a bug and your fix looks good.
>> Although I notice that your fix doesn't cover the case of a
>> new method
>> category being added. :-)  If you submit another fix for
>> this, go ahead
>> and post under a new subject, since it is separate from KCP220.
>
> It is true that the little fix I posted does not cover the case when
> method categories are added. However, this is precisely what is fixed 
> by
> the changeset KCP220! This changeset addresses the fact that there were
> many missing notifications in the ClassOrganizer (for example when
> categories are added/removed).
>
> The reason for this was the fact that the class hierarchy of
> ClassOrganizer was conceptually wrong and it was therefore not possible
> to add these notifications without breaking other code. In KCP220, all
> this is fixed. This means that ClassOrganizer now issues all the
> necessary notifications when the class organization is changed.
>
>> I would prefer to see this fix in because we still have time and this
>> way this will be fixed in 3.7
>
> I have attached an updated version of the KCP220 changeset to this
> email. The main differences to the previous changeset is that it also
> includes the little bugfix I sent on April 8, and that it fixes a 
> little
> typo. I have now extensively used this changeset for a few days where I
> recompiled the whole image many times and played a lot with the class
> organization.
>
> Of course, I can still not rule out that there is a small bug somewhere
> in this changeset. But I'm almost 100% certain that this changeset 
> fixes
> much more bugs than it introduces. So, if Marcus can review this
> changeset in time and thinks that it is fine, I suggest to put it into
> v3.8. This would be good because it would mean that the
> SystemChangeNotification framwork would actually be working the way it
> is supposed to.
>
> What do you guys think?
> Nathanael
> <KCP-0220-ClassOrganizerFixAndCleanup.14.cs>




More information about the Squeak-dev mailing list