[BUG][FIX] Smalltalk condenseChanges broken in 3.7beta

stéphane ducasse ducasse at iam.unibe.ch
Fri Apr 23 14:20:43 UTC 2004


Hi Boris

> It is not difficult to identify and to explain the bug, but it
> is a bit more difficult to find a fix that is in line with the
> intentions of the KCP (kernel cleanup project) team.
>
> ChangeList brrwoseRecentLog  needs a postion in
> the changes files that was, for a log time, stored in the
> class variable LastQuitLogPosition of  SystemDictionary.
> Now that file position is stored in class variable
> LastQuitLogPosition of class SmalltalkImage. However,
> the class variable LastQuitLogPosition of SystemDictionary
> is still not removed and
> SystemDictionary>>condenseChanges updates that
> variables but not those in SmalltalkImage.
> Attached is a change that updates the class
> variable in SmalltalkImage but not that in
> SystemDictionary. The class variables
> LastImageName and LastQuitLogPosition of
> SystemDictionary are not used any longer and
> will soon be removed (I hope so, because currently
> they cause nothing but problems).

OOPS my mistake
Boris could you propose a fix for that I will review it. Now I have no 
time

>
> Note that with the current protocol of SmalltalkImage,
> you need the instance  SmalltalkImage current  to send
> the message  lastQuitLogPosition:  which, in turn,
> assigns a value to a class variable:
>
>
>  SmalltalkImage current lastQuitLogPosition: f position.
>
>
> This looks strange and it is strange; class variables are normally
> accessed by the class protocol. Perhaps SmalltalkImage is a bit
> overdesigned? Currently it is used as a signleton and I do not
> think that this will be changed.
>
> Greetings, Boris<condenseChangesFix-bg.cs>




More information about the Squeak-dev mailing list