[FIX] Week-missing-startDay-send-jf ([er][et][sm] approve please)

Avi Bryant avi at beta4.com
Sat Apr 24 02:11:42 UTC 2004


The bug is real, and this is the right fix.

This reminds me of my monthAndYearInDate fix, which was reviewed but 
never approved, and which also really needs to get in - otherwise any 
calendar code that worked in 3.6 will break in 3.7.

On Apr 23, 2004, at 3:00 PM, julian at beta4.com wrote:

> This is a pretty important fix to go in before we leave beta, I think.
>
> from preamble:
>
> "Change Set:		Week-missing-startDay-send-jf
> Date:			23 April 2004
> Author:			Julian Fitzell
>
> Week (class)>>starting:duration: was accessing StartDay directly rather
> than calling #startDay.  This caused it to bypass the lazy
> initialization of StartDay.
>
> The bug can be noticed by doing:
>
> Date today asMonth weeks first dates first dayOfWeek
>
> It should return 1 (Sunday) but returns 7 (Saturday) in a new image
> without this fix."!
> <Week-missing-startDay-send-jf.cs.gz>




More information about the Squeak-dev mailing list