[BUG] [FIX] ClickState Recursion (sm) (but not minor)

Peace Jerome peace_the_dreamer at yahoo.com
Mon Aug 9 02:21:43 UTC 2004


karl wrote:

>Attachment did not show up properly in BFAV
>Karl
>
What needs to be done next? 

I have reattached the gzipped changes with the names
shortened to get around the limits of my OS 9
macintosh.

--Jer


>Jerome Peace wrote:
>> 
>> The problem:(See also recent bug report)
>> 
>> MouseClickState>>handleEvent:from:  is nonrecursive
>> except at one point where it is processing the
first
>> mouseup. There it calls handleEvent: with a copy of
>> the mouseup event after firing the click selector.
>> 
>> I've check with a diagnostic and this is definitely
a
>> recursive call. The same mouseup comes thru a
second
>> time (the click state has changed. And the
recursive
>> event glides thru without causing anymore changes.)
>> The recursive call releases it back to handleEvent
>> with the true flag. It is processed to completion.
>> 
>> When handleEvent exits the remaining unrecursed
event
>> is released back to handleEvent with the original
>> false flag. Furthur processing is not done and
>> handleEvent releases back to its original caller.
>> 
>> I do not believe this is what was actually
intended.
>> But I do not understand what the actual intention
was
>> either.
>> 
>> Changing the code so that instead of
>> 
>> self click.
>> aHand handleEvent: copiedEvt .
>> ^false
>> 
>> we have just:
>> 
>> self click.
>> ^true
>> 
>> would seem to do the trick as far as the post
>> processing results are concerned.
>> 
>> Some times the most useful thing you can think to
do
>> is poke something. Here is the method changed as
>> indicated.
>> 


		
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - Send 10MB messages!
http://promotions.yahoo.com/new_mail 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CSRecurseFix-wiz.1.cs.gz
Type: application/x-gzip
Size: 1421 bytes
Desc: CSRecurseFix-wiz.1.cs.gz
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20040808/78e4968e/CSRecurseFix-wiz.1.cs.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CSDiagnostics-wiz.cs.gz
Type: application/x-gzip
Size: 2029 bytes
Desc: CSDiagnostics-wiz.cs.gz
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20040808/78e4968e/CSDiagnostics-wiz.cs.bin


More information about the Squeak-dev mailing list