[BUG][FIX] DRNPFix

Frank Shearar Frank.Shearar at rnid.org.uk
Wed Aug 18 10:41:58 UTC 2004


>>> karl.ramberg at chello.se:
> 
> "Change Set:		DRNPFix
> Date:			18 August 2004
> Author:			Karl Ramberg
> 
> Several class initialization messages to DRNP did not open a 
> window (For
> squeak source version 169"

Thanks for the changeset, Karl. The change you made to DNRP>>openOn:'s a no-op, isn't it?

Yours:

openOn: aPost 
	| window |
	window _ (self on: aPost) createBfavReplyWindow:aPost.
	^ window openInWorld

Original:
openOn: aPost 
	^ ((self on: aPost) createBfavReplyWindow:aPost) openInWorld

I had at first thought the other two changes were just Introduce Explaining Variable refactorings, but then I realised that it's the cascade that's the problem, isn't it?

So I'm thinking of committing your changes to DNRP>>openOnChangeSet: and DNRP>>openOnContextPart:. Do you agree?

frank


*******************************************************************
This email and any files transmitted with it are confidential
and intended solely for the use of the individual or entity to
whom they are addressed. Any views or opinions expressed
are solely those of the author and do not necessarily represent
RNID policy.
If you are not the intended recipient you are advised that any
use, dissemination, forwarding, printing or copying of this
email is strictly prohibited.
If you have received this email in error please notify the RNID
Helpdesk by telephone on: +44 (0) 207 296 8282.
The Royal National Institute for Deaf People
Registered Office 19*23 Featherstone Street
London EC1Y 8SL No. 454169 (England)
Registered Charity No. 207720
********************************************************************




More information about the Squeak-dev mailing list