[BUG][FIX] DRNPFix
Karl Ramberg
karl.ramberg at chello.se
Wed Aug 18 14:21:33 UTC 2004
Frank Shearar wrote:
>
> >>> karl.ramberg at chello.se:
> >
> > "Change Set: DRNPFix
> > Date: 18 August 2004
> > Author: Karl Ramberg
> >
> > Several class initialization messages to DRNP did not open a
> > window (For
> > squeak source version 169"
>
> Thanks for the changeset, Karl. The change you made to DNRP>>openOn:'s a no-op, isn't it?
>
> Yours:
>
> openOn: aPost
> | window |
> window _ (self on: aPost) createBfavReplyWindow:aPost.
> ^ window openInWorld
>
> Original:
> openOn: aPost
> ^ ((self on: aPost) createBfavReplyWindow:aPost) openInWorld
>
> I had at first thought the other two changes were just Introduce Explaining Variable refactorings, but then I realised that it's the cascade that's the problem, isn't it?
Yes, it sent openInWorld to DRNP class.
> So I'm thinking of committing your changes to DNRP>>openOnChangeSet: and DNRP>>openOnContextPart:. Do you agree?
>
Fine
Karl
More information about the Squeak-dev
mailing list
|