[ENH] PNGReadWriter writing support & alpha fixes (v3)
Avi Bryant
avi at beta4.com
Fri Feb 13 00:16:33 UTC 2004
On Feb 12, 2004, at 2:35 PM, Bert Freudenberg wrote:
>
> Am 12.02.2004 um 23:03 schrieb Andreas Raab:
>
>> This is now v3 which fixes a bad, bad CRC issue, adds CRC validation
>> and
>> hopefully fixes the byte-sex problems.
>>
>> Avi - if you give this a try and the tests fail, can you send me the
>> generated test images (they will be written out automatically).
>> Off-list
>> please ;-)
>
> Oh, it's worse than before - it crashes the MacVM (log attached for
> John)! After commenting out test8BitDisplay the tests run with this
> result: 24 run, 23 passed, 0 failed, 1 error. The error is in
> test4BitDisplay (error out of bounds in ZipEncoder. But the tests seem
> to be wrong too, as none of the generated test images can be loaded by
> another application (Preview in my case). I'll send the images
> off-line.
Hm... I get 24 run, 24 passed (I tried the 3.6.1beta3, 3.7.1beta2, and
3.6g-2 VMs). But the images are still corrupt.
Bert, did you load v3 into a clean image or on top of v2? I'm
wondering what the difference might be.
I'm using the 3.6basic image.
More information about the Squeak-dev
mailing list
|