[ENH] PNGReadWriter writing support & alpha fixes (v3)
Bert Freudenberg
bert at impara.de
Fri Feb 13 08:09:12 UTC 2004
Am 13.02.2004 um 01:16 schrieb Avi Bryant:
>
> On Feb 12, 2004, at 2:35 PM, Bert Freudenberg wrote:
>
>>
>> Am 12.02.2004 um 23:03 schrieb Andreas Raab:
>>
>>> This is now v3 which fixes a bad, bad CRC issue, adds CRC validation
>>> and
>>> hopefully fixes the byte-sex problems.
>>>
>>> Avi - if you give this a try and the tests fail, can you send me the
>>> generated test images (they will be written out automatically).
>>> Off-list
>>> please ;-)
>>
>> Oh, it's worse than before - it crashes the MacVM (log attached for
>> John)! After commenting out test8BitDisplay the tests run with this
>> result: 24 run, 23 passed, 0 failed, 1 error. The error is in
>> test4BitDisplay (error out of bounds in ZipEncoder. But the tests
>> seem to be wrong too, as none of the generated test images can be
>> loaded by another application (Preview in my case). I'll send the
>> images off-line.
>
> Hm... I get 24 run, 24 passed (I tried the 3.6.1beta3, 3.7.1beta2, and
> 3.6g-2 VMs).
I'm on 3.6.1b5.
> But the images are still corrupt.
It seems to be a very special version of PNG that only Squeak
understands ;-)
pngtopnm says "fatal libpng error: Not enough image data"
> Bert, did you load v3 into a clean image or on top of v2? I'm
> wondering what the difference might be.
> I'm using the 3.6basic image.
This was a fully updated 3.7a image, with v3 loaded over v2.
- Bert -
More information about the Squeak-dev
mailing list
|