[ENH] SoundSystemCleanup-gk ( [er][et] needs a little work )

Brian Brown rbb at techgame.net
Tue Feb 24 03:59:04 UTC 2004


Quoting goran.krampe at bluefish.se:

> My firm suggestion is to make this much simpler:
> 
> - Only have #play on the instance side. Also explain in the class
> comment that an instance of Beeper is the default playable entity. I
> just rewrote the class comment with this and other improvements.
> 
> - Only have #beep and #beepPrimitive on the class side thus not
> ecouraging people to write stuff like "Beeper play" etc.
> 
> - Proper method comments explaining why people should use #beep instead
> of #beepPrimitive. I have added this.
> 
> Furthermore if you look at the code I have submitted it modified
> Beeper>>play to be:
> 
> 	SoundService default beep
> 
> (I renamed SoundSystem to SoundService - and no, I will not discuss the
> naming at this point :)
> 

I wholeheartedly agree with this logic; that is much, much cleaner and easier to
understand. Especially considering that I'm not writing it. :-)


-- 
Brian Brown
TechGame Networks, LLC.
http://www.techgame.net



More information about the Squeak-dev mailing list