[ENH] SMTPClientSenderBracket-nk ([er][et][sm][sl] Looks good;
test attached)
Lex Spoon
lex at cc.gatech.edu
Wed Mar 24 03:22:30 UTC 2004
"Frank Shearar" <frank.shearar at rnid.org.uk> wrote:
> So MailAddressParser Does The Right Thing already! Whee! Herewith attached
> then a changeset with my previously-mentioned implementation, plus a
> suitably amended test case.
Just reading the code, this looks great. The change to SMTPClient is
fine, and the test is excellent. I haven't actually run the test.
Also, the MockSocketStream that is included looks useful for other test
cases in the future.
-Lex
More information about the Squeak-dev
mailing list
|