[ENH] HilightCurrentFontChoices ([er][et] a couple minor code
issues)
Doug Way
dway at mailcan.com
Thu Mar 25 20:09:17 UTC 2004
Thomas A Petersen wrote:
>I haven't done a formal code review or unit tests, so I'm not adding [er]
>or [et] to the subject line. It works in a plain image as well as my super
>bloated giant one with the bitstream and other odd true type fonts loaded
>too.
>
>
The fact that you've tested it by trying it in the UI counts as an [et],
I'd say. (These types of UI changes are tougher to write unit tests for
anyway.)
I just tried it myself and it looks good!
There are a couple of minor issues with the code.
AbstractFont>>textStyleName is in the method category
"*ft2-fonts-accessing", which sounds like Ned's original FreeType2
package. Even if you originally copied it from that package, you should
put it in a new category (such as "accessing"), since it's no longer in
Ned's (or any other) package.
Also, I would use the regular spelling of "highlight" everywhere and not
the semi-abbreviated "hilight"... usually we don't abbreviate method
names in Squeak code, except in rare cases. (Besides, if you're going
to abbreviate, it should really be "hilite". ;-) )
- Doug
More information about the Squeak-dev
mailing list
|