[BUG] Selecting Color Dropper in Paint Project freezes image
Ned Konz
ned at bike-nomad.com
Wed Mar 31 21:10:34 UTC 2004
On Wednesday 31 March 2004 11:57 am, Frank Caggiano wrote:
> Note: this will freeze the image and force you to exit without saving
> (for me at least).
>
> In a 5816 image
> - open a paint project by dragging out from the widgets flap or clicking
> on the paintbrush in the Navigator flap.
> - select the dropper.
> - click either in the color selector box or anywhere else in the image.
> Image freezes. I'm unable to interrupt it.
>
> Works ok in 5764. Did I miss a fix?
One that didn't get into the update stream yet. It was called
MVCEventSensorFixes-nk and was posted on the 16th.
What happened is that the EventSensor changes made Sensor polling not work
right.
And then I posted the fix, but the behavior is still different:
With my fix, the image doesn't hang, but the hand position doesn't update.
If you look at PaintBoxMorph>>eyedropper:action:cursor:evt: you'll see that
its first loop (with no buttons pressed) makes sure to update the Hand
position, but the waitNoButton doesn't.
Really, one of two things needs to happen (in addition to loading my
changeset). Either:
- we change the EventSensor wait* methods so that they update the Hand (or
equivalent in MVC?), or
- we hunt down all the (Morphic) senders of 'Sensor waitXXX' and change them
to something more Morphic-friendly. In this specific case (where we want high
performance), it would be easy to just rewrite the method in the
PaintBoxMorph.
Other modal dialogs (like for instance the menus) do their own loops by
calling World>>doOneCycle but this would be much less smooth if there was any
stepping or motion going on.
Try my EyedropperEventFix-nk that I just posted.
--
Ned Konz
http://bike-nomad.com
GPG key ID: BEEA7EFE
More information about the Squeak-dev
mailing list
|