[FIX] NicerProjectFromUrl-bp ( [er] Looks good; improvement, but: )

Bernhard Pieber bernhard at pieber.com
Wed Feb 16 21:26:11 UTC 2005


frank.shearar at rnid.org.uk wrote:
> First, I think the code's a good start at cleaning up the Url code.
Thanks!

> And, provided you use my toText->asString changeset, Scamper's happy
> with the changes.
The third version uses asString now.

> Now time for my "but": I think we need some sort've mechanism so
> packages can add to the list of known URLs. For instance, my SIP package
> uses a SipUrl, and currently that package changes Url's code directly
> (in an analogous way to HttpUrl and friends).
I most emphatically agree with you! Factoring out that method was just
the first step in that direction.

> Mind you, maybe that's something for the next changeset! (One of my
> first thoughts was having something in SubclassOfUrl class>>initialize
> add to a collection in Url.
Yes, I would also implement it that way.

Thanks for reviewing my stuff!

- Bernhard




More information about the Squeak-dev mailing list