Nope, embarrassingly enough, I didn't notice that, because I didn't run 
the tests. That's pretty surprising, since I didn't think I was 
affecting that stuff at all. If someone wants to have a look, you're 
welcome to it, as I'm busy with travel at the moment. This change to 
ClassBuilder is important for Traits.

Daniel

stéphane ducasse wrote:
> Hi daniel,
> 
> Am I correct that you change is only in the method
> name: className inEnvironment: env subclassOf: newSuper type: type  
> instanceVariableNames: instVarString classVariableNames:  classVarString 
> poolDictionaries: poolString category: category  unsafe: unsafe?
> 
> I  run the tests and you change breaks
> 
> ClassBuilderFormatTests>>testByteVariableSubclass
> ClassBuilderFormatTests>>testWordVariableSubclass
> 
> ClassBuilderChangeClassTypeTest>>testClassCreationAndChange
> was failing in 3.7, 3.8, 6693 and it is still broken.
> 
> Can you have a look?
> Did the tests run on your side?
> 
> Stef
>