More problems with condenseSources
Yoshiki Ohshima
yoshiki at squeakland.org
Tue Apr 11 22:53:11 UTC 2006
Duh, forget about this. I meant to loop to find the last occurence
of given argument in the method, but the implementation actually
doesn't do it...
-- Yoshiki
At Tue, 11 Apr 2006 15:48:16 -0700,
Yoshiki Ohshima wrote:
>
> Andreas,
>
> > Thanks Dan and Yoshiki. While digging around some of the code I ran into
> > #backChunk which was new to me and actually does the Right Thing (tm) by
> > merely reading the previous chunk instead of an arbitrary number of
> > characters (Yoshiki's fix failed in situations where we have short names
> > since when using MultiByteFileStream it's reading the last 100 chars
> > which might easily include more than a single method).
>
> Uh, because mine checks the last occurence of '! !' (which should be
> at the end of each method), short names should be fine. But,
> #backChunk, though looks like slower, should do the right thing, yes.
>
> -- Yoshiki
More information about the Squeak-dev
mailing list
|